Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Add Nix instructions to readme #22

Merged
merged 1 commit into from
Dec 24, 2021
Merged

Conversation

siraben
Copy link
Contributor

@siraben siraben commented Dec 23, 2021

fq is packaged in Nixpkgs as of NixOS/nixpkgs#151871, so these instructions will work within a few days (once the master channel advances.)

@jtojnar
Copy link

jtojnar commented Dec 23, 2021

That requires Nix flakes enabled.

@siraben
Copy link
Contributor Author

siraben commented Dec 23, 2021

@jtojnar do you recommend using nix-shell -p fq instead?

@siraben
Copy link
Contributor Author

siraben commented Dec 23, 2021

Fixed to use stable Nix nix-shell

@wader
Copy link
Owner

wader commented Dec 23, 2021

@siraben Thanks, I don't much about nix (but want to know more!) so let me know when and what to do.

@siraben
Copy link
Contributor Author

siraben commented Dec 23, 2021

@siraben Thanks, I don't much about nix (but want to know more!) so let me know when and what to do.

Sure thing. For the purposes of this PR, like homebrew, Nixpkgs is a monorepo of package definitions, but users use channels, which are essentially points in the repo that have passed all the relevant tests. As such the instructions in this PR wouldn't work right away until the PR has made its way through the channels (see the PR tracker). I'll check periodically until it's green then ping again 😄

Thanks a lot for writing fq by the way!

@wader
Copy link
Owner

wader commented Dec 23, 2021

👍 has been a pleasure to write it! hope it's useful and let me know if something seems strange or hard to understand, there are some murky areas in fq that has some accidental design atm.

@siraben
Copy link
Contributor Author

siraben commented Dec 24, 2021

Rebased on master.

@siraben
Copy link
Contributor Author

siraben commented Dec 24, 2021

Good to merge now, it's made its way to the unstable channel.

@wader wader merged commit 5513dc0 into wader:master Dec 24, 2021
@siraben siraben deleted the nix-instructions branch December 24, 2021 04:32
@portothree
Copy link

Hey @siraben, sorry for jumping on this after it's already merged, but why are nix-shell -p being used in the section for installation? This is not actually installing the package, it's just spawing a new shell with the jq available there. The user would then need to run nix-shell -p everytime they want to use it.
It should instead be nix-env -iA nixpkgs.fq for non-NixOs and nix-env -iA nixos.fq for NixOS, this will make fq available everywhere in the system. Unless I'm missing something and there's a good reason to use the current command, happy to hear the reasoning.

@siraben
Copy link
Contributor Author

siraben commented Dec 27, 2021

@portothree generally people in the Nix community want to avoid promoting nix-env (because to new users there can be confusing behavior with nix-env -u among other things), so I followed that convention here. Bringing it in line with the pacman and brew commands is probably fine, though.

@wader
Copy link
Owner

wader commented Jan 14, 2022

Hey, i saw that @siraben updated to 0.0.3 in nixpkgs master 👍 but why does nix unstable still say 0.0.2? a bit confused with when things in master gets to unstable

@siraben
Copy link
Contributor Author

siraben commented Jan 14, 2022

https://nixpk.gs/pr-tracker.html?pr=154449 still not in nixos-unstable yet

@wader
Copy link
Owner

wader commented Jan 14, 2022

Aha, thanks for the link, will keep an eye on it, i'm mostly just nix-curious :)

Updates for the -unstable channels typically take a few days after commits land in the master branch.

Now to understand how these builds work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants