-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bson: support all non-deprecated types and fix int/uint bugs #650
Conversation
👍 Nice, will review later this evening |
@@ -1,7 +1,6 @@ | |||
package bson | |||
|
|||
// https://bsonspec.org/spec.html | |||
// TODO: more types |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳
format/bson/testdata/test.fqtest
Outdated
# Run the code at https://go.dev/play/p/8YuESN04ACr and copy the base64 output. Then run: | ||
# | ||
# echo "<base64 output>" | base64 -D > test.bson | ||
# |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes sense to add the generate program to a file under format/bson/testdata
. Some reason it has to go thru base64 btw?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also thanks for good tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I can add the source for the Go program used to generate the test BSON document in format/bson/testdata
. There's no reason it needs to use base64, it was just a reliable way to copy binary data from a web browser into a terminal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aha makes sense
Looks good 👍 just some minor things about docs and tests |
Will merge once CI is green. Thanks a lot! |
Fails on testing
Sorry I forgot in the review that To be clear the markdown in BTW if you want you can also add authors section, something like:
|
@wader Thanks for the feedback and recommendations! I think I've made all the changes and fixes you suggested. |
@matthewdale 🥳 Thanks and let me know if you have any question about the other improvements we talking about, happy to help out! |
javascript
elements.decimal128
elements (only printing as binary for now, with a TODO to parse the decimal128 value).minkey
andmaxkey
elements