-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #331 - Added ExternalIdFieldName to JobInfo, and overloads to po… #334
Conversation
How long does it typically take for a fix like this to be merged and released? |
Thanks, @Zhaph. @mschmidt-healthx I can try to prioritize it this week. I haven't looked at the details. Do you need it soon? |
We're getting ready to start a new project and will need to use bulk upsert - so trying to plan out whether I need to allow more time to work around this. It doesn't seem like it would be too big of a deal to manually call the job create API and then walk through the rest of RunJobAsync with a crafted JobInfoResult but it'd be nice if I didn't have to ;) Just a happy coincidence that I noticed that bulk upserts wouldn't work through the sdk this morning and a pull request had been submitted less than a day ago to fix it. |
No worries @wadewegner apologies for the flurry of commits after the pull request. I've got an updated test using the Campaign object and native fields if that would help? Apparently you can use (almost) any indexed field as the External Id for an upsert but you do need to specify it. |
@Zhaph thanks for this! Ran into the same problem myself and your changes worked great. |
I terribly need this bulk upsert functionality, can you please let me know when this will be updated in master and Nuget package. Thanks |
Another impressive contribution, @Zhaph! Thank you so much. I'm terribly sorry it's taken so long to merge. |
This fixes #331
Added
ExternalIdFieldName
to theJobInfo
class along with auto filling specified property to hide from XML if not required.Added overloads to the
RunJobAsync
,RunJobAsyncAndPollAsync
andCreateJobAsync
methods onForceClient
to allow ExternalIdFieldName to be supplied, along with an argument check when operation type is Upsert.Added optional test in
BulkForceClientFunctionalTests
to verify going forward - requires a new External Id field to be added to an object (I've addedUnique_Email__c
toContact
because that's where I needed it most, but happy to move it).