Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return initial response if can't parse #378

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/CommonLibrariesForNET/JsonHttpClient.cs
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,19 @@ public JsonHttpClient(string instanceUrl, string apiVersion, string accessToken,

private static ForceException ParseForceException(string responseMessage)
{
var errorResponse = JsonConvert.DeserializeObject<ErrorResponses>(responseMessage);
ErrorResponses errorResponse;

try
{
errorResponse = JsonConvert.DeserializeObject<ErrorResponses>(responseMessage);
}
catch (Exception e)
{
// return initial response if can't parse
// <h1>Bad Message 414</h1><pre>reason: URI Too Long</pre>
return new ForceException(Error.Unknown, responseMessage + Environment.NewLine + e.Message);
}

return new ForceException(errorResponse[0].ErrorCode, errorResponse[0].Message);
}

Expand Down