[WC-59] feat : LoadingProvider 구현 및 적용 #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wc-59/feat/LoadingProvider
|
✔️ Deploy Preview for wafflecard ready! 🔨 Explore the source changes: 863f8b8 🔍 Inspect the deploy log: https://app.netlify.com/sites/wafflecard/deploys/622f21d13d67f000080131a1 😎 Browse the preview: https://deploy-preview-34--wafflecard.netlify.app/ |
yyoooon
reviewed
Mar 16, 2022
| <Router /> | ||
| </WaffleCardsProvider> | ||
| </ModalsProvider> | ||
| </LoadingProvider> |
There was a problem hiding this comment.
그럼 Spinner컴포넌트는
</ModalsProvider>
여기에
</LoadingProvider>
항상 있는 거고 필요한 페이지에서 true, false해서 보여지고 안보여지게 하는 거 맞죠??
There was a problem hiding this comment.
이거 리뷰해놓고 제출을 안하고있었네요 ㅠㅠㅋㅋ
There was a problem hiding this comment.
@yyoooon
Spinner 컴포넌트 </LoadingProvider> 에서만 관리해여!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚅 PR 한 줄 요약
LoadingProvider 구현 및 적용
🧑💻 PR 세부 내용