친구 탭 React Native 베이스 브랜치 #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuTaK97
force-pushed
the
jutak/rn
branch
5 times, most recently
from
61c54de to
6e0b629
Compare
JuTaK97
force-pushed
the
jutak/rn
branch
3 times, most recently
from
999e99a to
3e558c6
Compare
JuTaK97
commented
Sep 9, 2023
Comment on lines
85
to
89
| val isDarkMode = if (userViewModel.themeMode.value == ThemeMode.AUTO) { | ||
| isSystemDarkMode(applicationContext) | ||
| } else { | ||
| userViewModel.themeMode.value == ThemeMode.DARK | ||
| } |
There was a problem hiding this comment.
화면 모드 바꾸고 친구탭 들어가면 반영이 안됨.... themMode를 collect 해서 ReactNativeBundleManager를 갈아끼워야 하나??
사진은 친구탭 -> 화면 모드 라이트에서 다크로 변경 -> 다시 친구탭 들어간 화면
There was a problem hiding this comment.
그거 나도 좀 고민했는데 걍 대응안해도 되지않을까
| PendingIntent.FLAG_ONE_SHOT, | ||
| PendingIntent.FLAG_ONE_SHOT or PendingIntent.FLAG_IMMUTABLE, |
There was a problem hiding this comment.
버전 올리고 컴파일 막혀서 수정
MyFirebaseMessegingServie 안쓰긴 하는데, 지우긴 좀 아까워서 냅둠
Comment on lines
+51
to
+72
| override fun getReactNativeHost(): ReactNativeHost { | ||
| return object : ReactNativeHost(this) { | ||
| override fun getUseDeveloperSupport(): Boolean = BuildConfig.DEBUG | ||
|
|
||
| override fun getPackages(): List<ReactPackage> = listOf( | ||
| MainReactPackage(), | ||
| RNScreensPackage(), | ||
| RNGestureHandlerPackage(), | ||
| RNCPickerPackage(), | ||
| SafeAreaContextPackage(), | ||
| ReanimatedPackage(), | ||
| SvgPackage(), | ||
| ) | ||
|
|
||
| override fun getJSMainModuleName(): String = "friends" | ||
|
|
||
| override fun getJavaScriptExecutorFactory(): JavaScriptExecutorFactory { | ||
| return HermesExecutorFactory() | ||
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
ReactApplication 상속 구현부
| init { | ||
| CoroutineScope(Dispatchers.IO).launch { | ||
| remoteConfig.waitForFetchConfig() | ||
| token.filter { it.isNotEmpty() }.collectLatest { |
There was a problem hiding this comment.
이렇게 하면 로그아웃 했다가 로그인 했을 때 ReactView랑 ReactInstanceManager를 새로 설정하게 된다.
Comment on lines
+38
to
+42
| if (BuildConfig.DEBUG && FlipperUtils.shouldEnableFlipper(this)) { | ||
| val client = AndroidFlipperClient.getInstance(this) | ||
| client.addPlugin(InspectorFlipperPlugin(this, DescriptorMapping.withDefaults())) | ||
| client.start() | ||
| } |
eastshine2741
approved these changes
Sep 10, 2023
This reverts commit 1bcb4c8.
This reverts commit 0de2035.
commit e3f5ca2d1e08bf9afb56477290a86cac24b90e1d
Author: 양주현 <didwngus01@naver.com>
Date: Thu Sep 7 21:20:09 2023 +0900
prod 빌드 되게 하기
test
17
고쳐야 하는 것
aab 체크
abi false
버전 롤백
뭐가 문제지
live도
17
Revert "17"
This reverts commit 1a5171f.
Revert "live도"
This reverts commit 14114f2.
Revert "뭐가 문제지"
This reverts commit 0b07a3b.
Revert "버전 롤백"
This reverts commit 223b137.
Revert "abi false"
This reverts commit 668523b.
Revert "aab 체크"
This reverts commit 7d7b025.
revert 후 cd만 셋팅
aab 받아보기
경로 수정
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
플로우
번들 파일이 없거나 손상됐으면 다운로드