Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

빈자리 배너 닫기 버튼 삭제 #210

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

eastshine2741
Copy link
Collaborator

@eastshine2741 eastshine2741 commented Aug 16, 2023

https://wafflestudio.slack.com/archives/C8M9NUBBR/p1691988515518239
유저가 배너를 닫을 수 없고, remoteConfig에 의해서만 배너의 on/off가 결정된다

  • 빈자리 배너 닫기 버튼 삭제
  • 배너가 열릴 다음 날짜 관련 로직 삭제

@eastshine2741 eastshine2741 requested a review from a team as a code owner August 16, 2023 06:19
Copy link
Collaborator

@JuTaK97 JuTaK97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JuTaK97
Copy link
Collaborator

JuTaK97 commented Aug 28, 2023

아직 작업 남았나?

@eastshine2741
Copy link
Collaborator Author

놉 머지할게

@eastshine2741 eastshine2741 merged commit d9089d8 into develop Aug 28, 2023
@eastshine2741 eastshine2741 deleted the eastshine2741/remove-banner-close branch August 28, 2023 07:29
@JuTaK97 JuTaK97 mentioned this pull request Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants