Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flipper 제거 #221

Merged
merged 1 commit into from
Sep 13, 2023
Merged

flipper 제거 #221

merged 1 commit into from
Sep 13, 2023

Conversation

JuTaK97
Copy link
Collaborator

@JuTaK97 JuTaK97 commented Sep 13, 2023

가이드 보면

dependencies {
  debugImplementation 'com.facebook.flipper:flipper:0.216.0'
  debugImplementation 'com.facebook.soloader:soloader:0.10.5'

  releaseImplementation 'com.facebook.flipper:flipper-noop:0.216.0'
}

로 하라고 돼있는데, release 빌드 할 때 터져서 (다른 사람들도 이슈 있다고 글 많음..) 그냥 빼기

이슈 없이 할라면 /debug/SNUTTApplication.kt/release/SNUTTApplication.kt 따로 만들고 해야되는것같은데 극혐이니까 안함

어차피 컴포즈앱에서 볼 수 있는 정보는 별로 없고, 전혀 다른 이유로 해결된 RN 이슈에서 레이아웃 볼라고 추가했던 거니까 필요할 때 추가해서 쓰기 (30초면 하니까)

@JuTaK97 JuTaK97 requested a review from a team as a code owner September 13, 2023 13:11
Copy link
Collaborator

@eastshine2741 eastshine2741 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ㅋㅋㅋㅋㅋㅋLGTM

@JuTaK97 JuTaK97 merged commit dca468f into develop Sep 13, 2023
3 checks passed
@JuTaK97 JuTaK97 deleted the jutak/remove-flipper branch September 13, 2023 13:29
@JuTaK97 JuTaK97 mentioned this pull request Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants