알림페이지 알림 타입 추가 #231
Merged
알림페이지 알림 타입 추가 #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
eastshine2741
commented
Dec 13, 2023
•
eastshine2741
commented
- fallback으로 megaphone icon 추가
- megaphone icon만 두께가 조금 달라서 추후 수정 필요. 길게 끌 일이 아니라서 일단 이대로 하기로 했다. 알림페이지 디자인 개편이랑 같이 수정될 예정
- 알림 제목을 하드코딩하지 않고 dto의 title을 표시하도록 수정
JuTaK97
approved these changes
Dec 23, 2023
Comment on lines
-51
to
+56
| else -> LazyColumn { | ||
| items(notificationList.itemCount) { index -> | ||
| NotificationItem(notificationList[index]) | ||
| else -> LazyColumn( | ||
| modifier = Modifier.padding(horizontal = 9.dp), | ||
| ) { | ||
| items(notificationList) { | ||
| it?.let { NotificationItem(it) } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.