타페이지에서 인증 안 돼서 인증페지이로 접근 시, 이메일 인증 완료 후 해당 페이지로 이동 #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woohm402
reviewed
Jul 8, 2024
| @@ -23,6 +23,7 @@ const TIMER_DURATION = APP_ENV === 'test' ? 3 * SECOND : 180 * SECOND; | |||
|
|
|||
| export const MailVerifyImpl = () => { | |||
| const router = useRouter(); | |||
| const from = router.query.from as string; | |||
There was a problem hiding this comment.
Suggested change
| const from = router.query.from as string; | |
| const from = router.query.from as string | undefined; |
가 맞을듯? string[] 은 발생할 일 거의 없으니 무시한다 쳐도 undefined 는 무시하면 안될거같어
| if (!is_email_verified && emailVerification === 'verified') { | ||
| const url = context.req.url; | ||
| const params = new URLSearchParams(); | ||
| url && !url.startsWith('/main') && params.set('from', url); |
There was a problem hiding this comment.
여기 'from' 이라는 문자열이 이 파일이랑 mainVerifyImpl/index.tsx 에서 지식의 중복이 일어난 것 같은데 src/entities/ 같은 데다가 export const EMAIL_VERIFY_FROM_KEY = 'from' 이런 식으로 상수로 빼면 좋을거같습니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Description
Screenshots
Focus
References