Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/colors/vivid_ios 마이그레이션 #296

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

Hank-Choi
Copy link
Contributor

@Hank-Choi Hank-Choi commented Nov 6, 2024

너무 짜치는 api인데 클래스 만들까 고민하다가
한번에 지울 수 있도록 router에서 바로 반환하도록 구성
라인 길어지는 것도 싫어서 파일 그대로 전달하는 방식으로 구성

@Hank-Choi Hank-Choi requested review from PFCJeong and a team as code owners November 6, 2024 16:08
@Hank-Choi Hank-Choi requested review from asp345, davin111 and SeonghaeJo and removed request for a team November 6, 2024 16:08
Copy link
Contributor

@SeonghaeJo SeonghaeJo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

서비스 레벨까지 갈 필요는 없을 것 같은데, MainRouter 코드가 지금도 길어서 LegacyHandler 같은 클래스 하나 만드는게 좋을 것 같아요

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants