Add vim like arrow, scroll, and close filtering motions #501
+68
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwendolyngoetz
approved these changes
Jan 29, 2024
mehmetumit
changed the title
gwendolyngoetz
approved these changes
Jan 29, 2024
gwendolyngoetz
approved these changes
Feb 2, 2024
gwendolyngoetz
approved these changes
Feb 2, 2024
gwendolyngoetz
approved these changes
Feb 10, 2024
|
Is there any update? Could you please take a look when you get a chance, @wagoodman ? Let me know if there's anything else you need from me. |
joschi
added a commit
to joschi/dive
that referenced
this pull request
Nov 7, 2024
) * Adding configurable keybindings for up/down arrows (`k` and `j` vim motions can be used as alternative to up/down arrows). Thanks to @gwendolyngoetz for implementing this feature [Adding configurable keybindings for up/down arrows wagoodman#499](wagoodman#499) * Add configurable keybindings for left/right arrows (`h` and `l` vim motions can be used as alternative to left/right arrows) * Add `u` and `d` keys for page up/down alternatives (I didn't want to replace default `ctrl+u` toggle-unmodified-files keybinding so I used`u` and `d` like `Vimium` extension ) * Add `esc` key to close filtering (Implemented a new method by utilizing the existing toggle filter method, without touching its current behavior) Refs wagoodman#129 Refs wagoodman#415 Refs wagoodman#499 Co-authored-by: Gwendolyn Goetz <gwendolyngoetz@users.noreply.github.com> Co-authored-by: Mehmet Ümit Özden <ozdenmehmetumit@gmail.com>
joschi
added a commit
to joschi/dive
that referenced
this pull request
Nov 7, 2024
) * Adding configurable keybindings for up/down arrows (`k` and `j` vim motions can be used as alternative to up/down arrows). Thanks to @gwendolyngoetz for implementing this feature [Adding configurable keybindings for up/down arrows wagoodman#499](wagoodman#499) * Add configurable keybindings for left/right arrows (`h` and `l` vim motions can be used as alternative to left/right arrows) * Add `u` and `d` keys for page up/down alternatives (I didn't want to replace default `ctrl+u` toggle-unmodified-files keybinding so I used`u` and `d` like `Vimium` extension ) * Add `esc` key to close filtering (Implemented a new method by utilizing the existing toggle filter method, without touching its current behavior) Refs wagoodman#129 Refs wagoodman#415 Refs wagoodman#499 Co-authored-by: Gwendolyn Goetz <gwendolyngoetz@users.noreply.github.com> Co-authored-by: Mehmet Ümit Özden <ozdenmehmetumit@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this pull request, some of the key controls discussed in #129 will be implemented.
kandjvim motions can be used as alternative to up/down arrows) Thanks to @gwendolyngoetz for implementing this feature Adding configurable keybindings for up/down arrows #499handlvim motions can be used as alternative to left/right arrows)uanddkeys for page up/down alternatives ( I didn't want to replace defaultctrl+utoggle-unmodified-files keybinding so I useduanddlikeVimiumextension )esckey to close filtering( Implemented a new method by utilizing the existing toggle filter method, without touching its current behavior)Additionally, once awesome-gocui/keybinding#5 is merged, it will be possible to use characters like
ö,ü,/. As a result, #129 and #415 issues will be completely solved.