Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consumer: close gracefully #166

Merged
merged 5 commits into from
Jun 21, 2024
Merged

Consumer: close gracefully #166

merged 5 commits into from
Jun 21, 2024

Conversation

thibleroy
Copy link

@thibleroy thibleroy commented Jun 17, 2024 •
edited
Loading

#150

Wait for consumer handler to finish before closing the channel and free up resources

Options:

  • use WithConsumerOptionsForceShutdown option to disable this beheviour
  • use consumer.CloseWithContext to cancel handler completion

@thibleroy thibleroy mentioned this pull request Jun 17, 2024
Closed
@astromechza
Copy link
Contributor

Thanks @thibleroy - this looks like a nice approach 👍

@wagslane wagslane merged commit 456bec0 into wagslane:main Jun 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thibleroy @astromechza @wagslane