Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support wagtail42 #246

Closed
wants to merge 30 commits into from

Conversation

nickmoreton
Copy link

@nickmoreton nickmoreton commented Feb 14, 2023

This updates the package to support Wagtail v4.2

Drops support for wagtail < 4.1

The following PR's have been included here.

Copy link

@victoriachan victoriachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I got an error about wagtailfontawesome

setup.py Outdated Show resolved Hide resolved
@victoriachan
Copy link

New changes look good, just need to fix warning about default_auto_field. Also the Readme needs updating as it says "Wagtail Personalisation requires Wagtail 2.0 or 2.1 and Django 1.11 or 2.0."!

Copy link
Author

@nickmoreton nickmoreton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@victoriachan I have fixed the console waring hopefully. Also updated the docs.
The imagery used in the docs is not right in terms of the look of the admin. Do you think we should update them?

src/wagtail_personalisation/__init__.py Outdated Show resolved Hide resolved
@katdom13
Copy link

Hi @nickmoreton ,
I'm not seeing the warning. Maybe these comments can be resolved?

@easherma-truth
Copy link
Collaborator

Any plans to merge this or the 5.2 PR soon?

@zerolab
Copy link
Collaborator

zerolab commented Jun 27, 2024

Closing in favour of #251

@zerolab zerolab closed this Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants