Better handle types when running optimisers #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main change here is adding an explicit type error, rather than having a variable not be defined. Secondly, the type handling itself gets simpler and slightly more optimised.
zerolab
reviewed
Jun 19, 2024
Co-authored-by: Dan Braghiș <dan@zerolab.org>
zerolab
approved these changes
Jun 19, 2024
|
Needs backporting to |
RealOrangeOne
added a commit
that referenced
this pull request
Jun 25, 2024
The main change here is adding an explicit type error, rather than having a variable not be defined. Secondly, the type handling itself gets simpler and slightly more optimised.
RealOrangeOne
added a commit
that referenced
this pull request
Jun 25, 2024
RealOrangeOne
added a commit
to RealOrangeOne/Willow
that referenced
this pull request
Jun 25, 2024
RealOrangeOne
added a commit
to RealOrangeOne/Willow
that referenced
this pull request
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #147
The main change here is adding an explicit type error, rather than having a variable not be defined.
Secondly, the type handling itself gets simpler and slightly more optimised.