Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up Prettier #169

Closed
Tracked by #56
lb- opened this issue May 12, 2022 · 0 comments · Fixed by #262
Closed
Tracked by #56

Set up Prettier #169

lb- opened this issue May 12, 2022 · 0 comments · Fixed by #262

Comments

@lb-
Copy link
Member

lb- commented May 12, 2022 •
edited
Loading

Similar to Wagtail core, Prettier should be used for formatting all files it supports (potentially even markdown).

See https://github.com/wagtail/wagtail/wiki/Updating-PRs-for-linting-changes for instructions on how to format a codebase without it creating noise when using git blame.

Ensure it does not conflict with the editorconfig settings, or maybe those settings need updating. https://github.com/wagtail/sphinx_wagtail_theme/blob/main/.editorconfig
@lb- lb- mentioned this issue May 12, 2022
Closed
6 tasks
@lb- lb- changed the title Setting up Prettier Set up Prettier May 12, 2022
lb- pushed a commit to lb-/sphinx_wagtail_theme that referenced this issue Jul 14, 2023
Adds Prettier
0dd3bf9 
Closes wagtail#169
@lb- lb- mentioned this issue Jul 14, 2023
Merged
lb- pushed a commit to lb-/sphinx_wagtail_theme that referenced this issue Jul 14, 2023
Adds Prettier
eac3a10 
Closes wagtail#169
lb- pushed a commit to lb-/sphinx_wagtail_theme that referenced this issue Jul 14, 2023
Adds Prettier
31273f4 
Closes wagtail#169
@lb- lb- closed this as completed in #262 Jul 14, 2023
lb- pushed a commit that referenced this issue Jul 14, 2023
@lb-
Adds Prettier
f633a06 
Closes #169
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Prettier formatter lb-/sphinx_wagtail_theme
1 participant
@lb-