Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downgrade css-loader #268

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Downgrade css-loader #268

merged 1 commit into from
Jul 19, 2023

Conversation

lb-
Copy link
Member

@lb- lb- commented Jul 18, 2023

Before

Screenshot 2023-07-19 at 7 38 02 am

After

Screenshot 2023-07-19 at 9 24 58 am

@lb-
Downgrade css-loader
9857506 
- V6 broke icon fonts
- Closes #257
@lb-
Copy link
Member Author

lb- commented Jul 19, 2023 •
edited
Loading

Vercel screenshot

Screenshot_20230719-173054

Percy failure is due to the timestamp in the footer so ignoring that for now.

laymonage
laymonage approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@laymonage laymonage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I wonder if it's possible to update the configuration so it works with v6?

@lb-
Copy link
Member Author

lb- commented Jul 19, 2023

I tried a few things, I thought it was better to get a patch release out first and then I'll raise an issue for a better fix.

@lb- lb- merged commit 2700143 into main Jul 19, 2023
@lb- lb- deleted the fix/267-fix-font-awesome-icon-font branch July 19, 2023 08:09
@lb- lb- mentioned this pull request Jul 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laymonage laymonage laymonage approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release 6.1.0 / 6.1.1
2 participants
@lb- @laymonage