Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve authentication options for GoogleCloudTranslator #645

Merged

Conversation

ababic
Copy link
Contributor

@ababic ababic commented Nov 3, 2022

This PR adds the CREDENTIALS_PATH and CREDENTIALS options to GoogleCloudTranslator, giving developers more control and (more importantly) a way to provide service account credentials when storing actual key files isn't an option.

@ababic ababic force-pushed the feature/google-cloud-translate-credentils-dict branch 11 times, most recently from 83194b8 to d727ccf Compare November 8, 2022 15:06
@ababic ababic force-pushed the feature/google-cloud-translate-credentils-dict branch 10 times, most recently from 5462621 to b2f9932 Compare November 12, 2022 20:51
@ababic ababic force-pushed the feature/google-cloud-translate-credentils-dict branch from b2f9932 to 8d4e1ce Compare November 12, 2022 21:01
@codecov-commenter
Copy link

Codecov Report

Base: 91.78% // Head: 91.66% // Decreases project coverage by -0.12% ⚠️

Coverage data is based on head (8d4e1ce) compared to base (fb4db60).
Patch coverage: 91.66% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #645      +/-   ##
==========================================
- Coverage   91.78%   91.66%   -0.13%     
==========================================
  Files          46       47       +1     
  Lines        3980     4006      +26     
  Branches      603      608       +5     
==========================================
+ Hits         3653     3672      +19     
- Misses        194      200       +6     
- Partials      133      134       +1     
Impacted Files Coverage Δ
wagtail_localize/machine_translators/google.py 78.26% <91.66%> (ø)
wagtail_localize/side_panels.py 47.61% <0.00%> (-2.39%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zerolab zerolab merged commit 95b2bb4 into wagtail:main Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants