Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django 1.7 support #497

Merged
merged 21 commits into from
Aug 27, 2014
Merged

Django 1.7 support #497

merged 21 commits into from
Aug 27, 2014

Conversation

kaedroho
Copy link
Contributor

All the bugs blocking the previous attempt to add Django 1.7 support seem to be fixed now.

Wagtail has moved on so much since then, so this pull request starts adding Django 1.7 support again from scratch.

  • Create initial schema migrations
  • Create initial data migrations
  • Update ElasticSearchQuerySet to use Django 1.7 where nodes
  • Get all tests working (one more test to go)
  • Test

How you can help:

@kaedroho kaedroho changed the title Django 1.7 support (take 2) [WIP] Django 1.7 support (take 2) Jul 23, 2014
@kaedroho kaedroho changed the title [WIP] Django 1.7 support (take 2) Django 1.7 support (take 2) Jul 25, 2014
@kaedroho
Copy link
Contributor Author

One test is still failing but I don't think the particular test in question is any cause for alarm.

This is now ready for review.

@kaedroho kaedroho changed the title Django 1.7 support (take 2) Django 1.7 support Jul 28, 2014
@kaedroho kaedroho added this to the 0.5 milestone Jul 28, 2014
@tomdyson tomdyson modified the milestones: 0.5, 0.6 Jul 29, 2014
@kaedroho
Copy link
Contributor Author

Is there anything wrong with merging this soon? I think it would be really useful to have the community test this and help fix any bugs before it is released. AFAIK, there are no regressions (the only bugs I know of affect only Django 1.7 users of which there are currently none).

@gasman gasman mentioned this pull request Aug 19, 2014
10 tasks
@kaedroho kaedroho mentioned this pull request Aug 22, 2014
@kaedroho
Copy link
Contributor Author

I've added a section to the top of this document showing the things that need to be done before Django 1.7 support is complete.

I wouldn't consider any of the above issues to be merge blockers (as they don't affect existing users) and would be perfectly acceptable to give Wagtail "Django 1.7 support is in alpha" status.

@sirex
Copy link

sirex commented Aug 24, 2014

Just did some manual testing with Django 1.7c2 and found no issues, everything seems to be ok.

+1 To merge it to master.

My code with Django 1.7c2 is here:
https://github.com/python-dirbtuves/akl.lt/tree/wagtail-django-17

@kaedroho
Copy link
Contributor Author

I've merged master into this branch and I've added instructions above for how to use this in your projects.

If anyone does use this, let us know how you get on and any bugs you come across.

@kaedroho
Copy link
Contributor Author

I've overwritten the migrations as some minor tweaks have been made to Djangos migration format recently. This appears to fix the Python 3 issues. I don't expect to have to do this again though.

@gasman
Copy link
Collaborator

gasman commented Aug 27, 2014

Unfortunately this is failing on sqlite (the 'py27-dj17-sqlite' environment in tox) with "KeyError: u'page_ptr'" during migrations.

@kaedroho
Copy link
Contributor Author

Just remade the migrations for the tests app which seems to fix the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants