Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should we consider printing error stack information when the process exits? #22

Closed
tianxidev opened this issue Nov 20, 2024 · 1 comment
Closed

Should we consider printing error stack information when the process exits? #22

tianxidev opened this issue Nov 20, 2024 · 1 comment

Comments

@tianxidev
Copy link
Contributor

tianxidev commented Nov 20, 2024 •
edited
Loading

Should we consider printing error stack information when the process exits?

File: github.com\wailsapp\go-webview2\pkg\edge\chromium.go
Line: 114-117

func (e *Chromium) errorCallback(err error) {
	e.globalErrorCallback(err)
	os.Exit(1)
}
@leaanthony
Copy link
Member

Good idea! Feel free to open a PR 🙏

@tianxidev tianxidev mentioned this issue Nov 23, 2024
Merged
leaanthony added a commit that referenced this issue Nov 23, 2024
@leaanthony
Merge pull request #23 from Tianxidev/tianxidev
43d9533 
feat: add stack trace printing upon exit  #22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@leaanthony @tianxidev