Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to request permissions for custom hosts #209

Closed
muety opened this issue May 11, 2023 · 7 comments · Fixed by #222
Closed

Allow to request permissions for custom hosts #209

muety opened this issue May 11, 2023 · 7 comments · Fixed by #222

Comments

@muety
Copy link

muety commented May 11, 2023

#130 introduced the ability to configure custom API URLs, so the plugin can be used with self-hosted WakaTime alternative like Wakapi as well. However, to actually use this, people would have to build their own version of the browser add-on with host_permissions configured to permit requests to their own instances.

I propose to ...

  • ... allow wakapi.dev by default.
  • ... to request for optional host permissions when custom URL is configured (see here, here and here).
@muety
Copy link
Author

muety commented Jun 17, 2023

What do you think, @alanhamlett? Would you be accepting a PR for this?

@alanhamlett
Copy link
Member

Yes, sounds good.

@alanhamlett
Copy link
Member

I don't want to allow wakapi.dev by default, but we should lazy-request permissions when any custom api url is used.

@varac
Copy link

varac commented Jul 27, 2023

@alanhamlett Could you please release a new version containing this change to fully support self-hosted backends ? Thanks !

@alanhamlett
Copy link
Member

@jvelezpo manages Chrome and Firefox releases, he can get a new version released.

@jvelezpo
Copy link
Contributor

jvelezpo commented Jul 28, 2023

@varac @alanhamlett the newest version is relaesed alredy to FF and chrome

FF

Last Updated: July 17, 2023
    Status:[ Approved ](https://addons.mozilla.org/en-US/developers/addon/wakatimes/versions)
    Listed Version: [3.0.17](https://addons.mozilla.org/en-US/firefox/addon/wakatimes/versions/)

Chrome

Version: 3.0.17
Last updated Jul 13, 2023
Status Published - public

Here is a SS with the latest version working with wakapi.dev
Screen Shot 2023-07-28 at 9 01 01 AM

@varac
Copy link

varac commented Jul 28, 2023

Sorry for that - I now see the proper wakapi API endpoint, with this it works ! Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants