Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: configure base url #179

Merged
merged 4 commits into from
Mar 28, 2023
Merged

chore: configure base url #179

merged 4 commits into from
Mar 28, 2023

Conversation

jvelezpo
Copy link
Contributor

Pre-PR Checklist

  • I have run npm test locally and there are no warnings or errors, from lint or test
  • I have added screenshots if applicable

Summary

Allows to configure API url, supporting "third-party" backends like Wakapi

#130

Screen Shot 2023-03-15 at 3 58 53 PM

Screen Shot 2023-03-15 at 3 59 17 PM

src/config/config.ts Outdated Show resolved Hide resolved
@jvelezpo jvelezpo changed the title Sebas configure base url chore: configure base url Mar 16, 2023
@alanhamlett
Copy link
Member

Shouldn't it be .../api/v1 to match the wakatime-cli default? https://github.com/wakatime/wakatime-cli/blob/develop/USAGE.md#ini-config-file

@jvelezpo
Copy link
Contributor Author

Shouldn't it be .../api/v1 to match the wakatime-cli default? https://github.com/wakatime/wakatime-cli/blob/develop/USAGE.md#ini-config-file

@alanhamlett now it is matching cli baseUrl
can you please review 👍

@jvelezpo jvelezpo requested a review from gandarez March 22, 2023 14:04
@jvelezpo jvelezpo merged commit c2ead51 into master Mar 28, 2023
@jvelezpo jvelezpo deleted the sebas-configure-base-url branch March 28, 2023 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants