Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add permission for (api.)wakatime.com on Firefox.
Request permission for the API URL set by the user.
Restrict content script to run on meet.google.com only. This involves some strange logic about the host permissions:
content_scripts.matches
, then the browser shows that the extension has permission to access data on that website. However, the background service worker cannot send cross-site requests to that URL.content_scripts.matches
andoptional_host_permissions
, then the background service worker can send cross-site requests to that URL.So it's not possible to inject content scripts on all websites but conditionally ask for cross-site request permissions for specific websites only.
Now it seems that the content script only works for meet.google.com. More websites may be added if needed later.
An alternative solution is to use
scripting.registerContentScripts()
to dynamically register content script for websites, so that users can reject permissions on some websites and continue to use the extension. This could be implemented later.This should fix #291