add test run on windows to ci #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gandarez
force-pushed
the
feature/ci-windows-tests
branch
from
2b52fe9 to
0549993
Compare
gandarez
force-pushed
the
feature/ci-windows-tests
branch
4 times, most recently
from
d4447c2 to
9b48547
Compare
gandarez
force-pushed
the
feature/ci-windows-tests
branch
from
9b48547 to
8f1ff94
Compare
|
Fixed all tests for Windows. The moral is not to use I will fix linter installation. |
|
@andy linting fixed. |
|
LGTM 👍 |
gandarez
approved these changes
Nov 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test run via github actions on a windows server to ci.
@gandarez Some tests are failing, expecially in
projectpackage. As you also work on a windows machine, can you fix these and push commits to this PR?