Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Control http.Client creation instead of using http.DefaultClient #395

Merged
merged 1 commit into from
May 21, 2021
Merged

Control http.Client creation instead of using http.DefaultClient #395

merged 1 commit into from
May 21, 2021

Conversation

alanhamlett
Copy link
Member

Setup http.Client in central location.

@alanhamlett alanhamlett mentioned this pull request May 20, 2021
Closed
@gandarez gandarez added the bug Something isn't working label May 20, 2021
dron22
dron22 approved these changes May 20, 2021
View reviewed changes
Copy link
Contributor

@dron22 dron22 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. All configurations make sense. As we do not expect, to fix the TLS bug here, it feels more like a feature though, right? 👍

@alanhamlett
Copy link
Member Author

it feels more like a feature though, right?

Yea, but possibly it would fix some default timeout issues since there was no timeout previously.

@alanhamlett alanhamlett force-pushed the bugfix/setup-http-client-manually branch from 2052676 to 9927a65 Compare May 21, 2021 16:56
@alanhamlett alanhamlett merged commit b971910 into develop May 21, 2021
@alanhamlett alanhamlett deleted the bugfix/setup-http-client-manually branch May 21, 2021 16:59
This was referenced May 22, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dron22 dron22 dron22 approved these changes

@gandarez gandarez Awaiting requested review from gandarez

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alanhamlett @dron22 @gandarez