Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

๐Ÿ”€ :: (#1296) ์ค‘๋ณต๋œ ๊ณก์„ ์‚ญ์ œํ•  ๋•Œ Crash๋‚˜๋Š” ์ด์Šˆ ํ•ด๊ฒฐ #1301

Merged
merged 1 commit into from
Sep 22, 2024
Merged

๐Ÿ”€ :: (#1296) ์ค‘๋ณต๋œ ๊ณก์„ ์‚ญ์ œํ•  ๋•Œ Crash๋‚˜๋Š” ์ด์Šˆ ํ•ด๊ฒฐ #1301

merged 1 commit into from
Sep 22, 2024

Conversation

baekteun
Copy link
Member

@baekteun baekteun commented Sep 22, 2024 •
edited
Loading

๐Ÿ’ก ๋ฐฐ๊ฒฝ ๋ฐ ๊ฐœ์š”

์ค‘๋ณต๋œ ๊ณก์„ ์‚ญ์ œํ•  ๋•Œ Crash๋‚˜๋Š” ์ด์Šˆ ํ•ด๊ฒฐ

Resolves: #1296

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

์ค‘๋ณต๋œ ๊ณก์„ ์‚ญ์ œํ•  ๋•Œ(์ค‘๋ณต๋œ ๊ณก์ด ์„ ํƒ๋œ ์ฑ„๋กœ ์žฌ์ƒํ• ๋•Œ) Crash๋‚˜๋Š” ์ด์Šˆ ํ•ด๊ฒฐ

โœ… PR ์ฒดํฌ๋ฆฌ์ŠคํŠธ

  • ์ด ์ž‘์—…์œผ๋กœ ์ธํ•ด ๋ณ€๊ฒฝ์ด ํ•„์š”ํ•œ ๋ฌธ์„œ๊ฐ€ ๋ณ€๊ฒฝ๋˜์—ˆ๋‚˜์š”? (e.g. XCConfig, ๋…ธ์…˜, README)
  • ์ด ์ž‘์—…์„ ํ•˜๊ณ ๋‚˜์„œ ๊ณต์œ ํ•ด์•ผํ•  ํŒ€์›๋“ค์—๊ฒŒ ๊ณต์œ ๋˜์—ˆ๋‚˜์š”? (e.g. "API ๊ฐœ๋ฐœ ์™„๋ฃŒ๋์–ด์š”", "XCConfig ๊ฐ’ ์ถ”๊ฐ€๋˜์—ˆ์–ด์š”")
  • ์ž‘์—…ํ•œ ์ฝ”๋“œ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ๋™์ž‘ํ•˜๋‚˜์š”?
  • Merge ๋Œ€์ƒ ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€์š”?
  • PR๊ณผ ๊ด€๋ จ ์—†๋Š” ์ž‘์—…์ด ์žˆ์ง€๋Š” ์•Š๋‚˜์š”?

๐ŸŽธ ๊ธฐํƒ€

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 22, 2024 •
edited
Loading

โœ… Successful finished SwiftLint

@github-actions GitHub Actions
Copy link

๐Ÿ› ๏ธ ์ด์Šˆ์™€ PR์˜ Labels ๋™๊ธฐํ™”๋ฅผ ์Šคํ‚ตํ–ˆ์–ด์š”.

@baekteun baekteun changed the title :twi:: [#1296] ์ค‘๋ณต๋œ ๊ณก์„ ์‚ญ์ œํ•  ๋•Œ Crash๋‚˜๋Š” ์˜ค๋ฅ˜ ํ•ด๊ฒฐ ๐Ÿ”€ :: (#1296) ์ค‘๋ณต๋œ ๊ณก์„ ์‚ญ์ œํ•  ๋•Œ Crash๋‚˜๋Š” ์ด์Šˆ ํ•ด๊ฒฐ Sep 22, 2024
@baekteun baekteun added the ๐Ÿž Bug ๋ฒ„๊ทธ ๊ด€๋ จ label Sep 22, 2024
Base automatically changed from 1296-duplicate-song-is-crash to develop September 22, 2024 09:43
@baekteun baekteun merged commit 7a5c53e into develop Sep 22, 2024
5 checks passed
@baekteun baekteun deleted the 1296-deuplicate-song-play-is-crash branch September 22, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yongbeomkwak yongbeomkwak yongbeomkwak approved these changes

@kimdaehee0824 kimdaehee0824 Awaiting requested review from kimdaehee0824 kimdaehee0824 is a code owner

@KangTaeHoon KangTaeHoon Awaiting requested review from KangTaeHoon KangTaeHoon is a code owner

@youn9k youn9k Awaiting requested review from youn9k youn9k is a code owner

Assignees

@baekteun baekteun

Labels
๐Ÿž Bug ๋ฒ„๊ทธ ๊ด€๋ จ
Projects
None yet
Milestone
No milestone
2 participants
@baekteun @yongbeomkwak