Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ”€ :: (#1314) Swift 6 ๋งˆ์ด๊ทธ๋ ˆ์ด์…˜ #1327

Merged
merged 13 commits into from
Dec 8, 2024

Conversation

baekteun
Copy link
Member

@baekteun baekteun commented Nov 25, 2024

๐Ÿ’ก ๋ฐฐ๊ฒฝ ๋ฐ ๊ฐœ์š”

  • Swift 6 ๋งˆ์ด๊ทธ๋ ˆ์ด์…˜
  • Strict Concurrency Complete ์ง€์›

Resolves: #1314
Resolves: #1315

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

๋Œ€์ถฉ ์—ฌ๋Ÿฌ๊ฐ€์ง€ Sendable ์ฑ„ํƒ ๋ฐ ๋กœ์ง Isolationํ™”

๐Ÿ™‹โ€โ™‚๏ธ ๋ฆฌ๋ทฐ๋…ธํŠธ

  • SongEntity์ด Mutableํ•˜๊ธฐ๋„ํ•ด์„œ ๋‹น์žฅ์€ ๋ฌธ์ œ์—†์–ด๋„ ์–ธ์  ๊ฐ€ ์ฒญ์‚ฐ์ด ํ•„์š”ํ•ด๋ณด์ž„
  • ์ตœ๋Œ€ํ•œ class๋“ค์€ Lock ๋‹ฌ์•„๋†“์•„์„œ ํ•ด๊ฒฐํ•ด๋†“์•˜์Œ
  • Tuist ๊ตฌ์„ฑ๋„ Swift 6 ์ง€์›๋˜๋Š”๊ฒŒ ์ดํ›„๋ฒ„์ „์ด๋ผ ๋ฒ„์ „ ์—…๊ทธ๋ ˆ์ด๋“œ
  • EditSheetViewType์ด์—ˆ๋‚˜? ContainerViewType์ด์—ˆ๋‚˜ protocol์ž์ฒด๊ฐ€ Mutableํ•˜๊ณ  ๋‚˜์ค‘์— View๋ฅผ ์ฃผ์ž…ํ•˜๋Š” ์–‘์ƒ์„ ๋ณด์ด๊ธฐ์— ViewController๋“ค์€ ์ •์ƒ์ ์ธ Sendable์„ ๋‹ฌ ์ˆ˜ ์—†์Œ. ์ฒญ์‚ฐ ํ•„์š”.
  • View ๊ด€๋ จ๋œ ๊ฒƒ๋“ค, ViewDelegate๋“ค์€ ๋ชจ๋‘ MainActor์—์„œ ์ฒ˜๋ฆฌ
  • static variable์€ ์ผ๋‹จ shared instance์˜ variable๋กœ ๋ณ€๊ฒฝ (PreferenceManager)
  • Needle์˜ ๊ฒฝ์šฐ Swift 6 ๋Œ€์‘์„ ํ•œ Generator CLI๋ฅผ ๋ฐฐํฌํ•˜์ง€ ์•Š์•„์„œ (๊นƒํ—™์—๋„ ์•ˆ๋˜์–ด์žˆ์Œ, PR๋งŒ ์˜ฌ๋ผ์˜ด;) ๋‹น์žฅ์€ ์ƒ์„ฑํ•ด๋†“์€ ์ด ์ฝ”๋“œ๋งŒ ์‚ฌ์šฉํ•˜๋„๋กํ•˜๊ธฐ ์œ„ํ•ด ์Šคํฌ๋ฆฝํŠธ Build Phase์—์„œ ์ž„์‹œ ์ œ๊ฑฐ
  • I hate Third Party T.T (Rx๋งŒ์ด ์•„๋‹ˆ๋ผ Moya, Reactor, Tabman ๋“ฑ๋“ฑ ์„œ๋“œํŒŒํ‹ฐ์—์„œ Swift 6๊ฐ€ ๋Œ€์‘๋˜์ง€ ์•Š์€ ๊ฒƒ์ด ์žˆ๊ธฐ ๋•Œ๋ฌธ์— preconcurrnecy๊ฐ€ ๋‹ค์†Œ ๋‹ฌ๋ ค์žˆ์Œ)
  • StoryboardView๋“ค์ด awakeFromNib์—์„œ UI๊ตฌ์„ฑํ• ๋•Œ MainActor๋ณด์žฅ์„ ์œ„ํ•ด Task๋กœ ๊ฐ์‹ธ๊ณ  ์žˆ์Œ. ์ด๋กœ์ธํ•ด ํƒ€์ด๋ฐ ์ด์Šˆ๊ฐ€ ์ƒ๊ธฐ๋Š”๊ฒŒ ์—†๋Š”์ง€ ๋”๋ธ”์ฒดํฌ ํ•„์š” @KangTaeHoon @yongbeomkwak @youn9k @wakmusic/wakmusic-ios-team

โœ… PR ์ฒดํฌ๋ฆฌ์ŠคํŠธ

  • ์ด ์ž‘์—…์œผ๋กœ ์ธํ•ด ๋ณ€๊ฒฝ์ด ํ•„์š”ํ•œ ๋ฌธ์„œ๊ฐ€ ๋ณ€๊ฒฝ๋˜์—ˆ๋‚˜์š”? (e.g. XCConfig, ๋…ธ์…˜, README)
  • ์ด ์ž‘์—…์„ ํ•˜๊ณ ๋‚˜์„œ ๊ณต์œ ํ•ด์•ผํ•  ํŒ€์›๋“ค์—๊ฒŒ ๊ณต์œ ๋˜์—ˆ๋‚˜์š”? (e.g. "API ๊ฐœ๋ฐœ ์™„๋ฃŒ๋์–ด์š”", "XCConfig ๊ฐ’ ์ถ”๊ฐ€๋˜์—ˆ์–ด์š”")
  • ์ž‘์—…ํ•œ ์ฝ”๋“œ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ๋™์ž‘ํ•˜๋‚˜์š”?
  • Merge ๋Œ€์ƒ ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€์š”?
  • PR๊ณผ ๊ด€๋ จ ์—†๋Š” ์ž‘์—…์ด ์žˆ์ง€๋Š” ์•Š๋‚˜์š”?

๐ŸŽธ ๊ธฐํƒ€

@baekteun baekteun changed the title Swift 6:twi ๐Ÿ”€ :: (#1314) Nov 25, 2024
Copy link

github-actions bot commented Nov 25, 2024

โœ… Successful finished SwiftLint

Copy link

โœ… Assign ์ž๋™ ์ง€์ •์„ ์„ฑ๊ณตํ–ˆ์–ด์š”!

@baekteun

@baekteun baekteun changed the title ๐Ÿ”€ :: (#1314) ๐Ÿ”€ :: (#1314) Swift 6 ๋งˆ์ด๊ทธ๋ ˆ์ด์…˜ Nov 25, 2024
@baekteun baekteun requested review from youn9k, KangTaeHoon and yongbeomkwak and removed request for yongbeomkwak December 6, 2024 01:37
Copy link
Member

@yongbeomkwak yongbeomkwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ˆ˜๊ณ ํ•˜์…จ์Šต๋‹ˆ๋‹ค
๋„ค์ด๋ฒ„ ๋กœ๊ทธ์ธ ๊ด€๋ จ ๊ฑด๋งŒ ๋น ๋ฅด๊ฒŒ ํ•ด๊ฒฐํ•˜๊ณ  ์˜ฌ๋ ค์ฃผ์‹  ์•ˆ๊ฑด๋“ค์€ ๋‚ด๋…„์— ํšŒ์˜ํ•œ๋ฒˆ ์žก์•„์„œ ์ง„ํ–‰ํ•ด๋ณด์ฃ 

@baekteun baekteun merged commit 2329b98 into develop Dec 8, 2024
3 checks passed
@baekteun baekteun deleted the 1314-swift-6-migration branch December 8, 2024 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants