Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ”€ :: (#424) ๋ชจ๋“ˆ ์ƒ์„ฑ ์Šคํฌ๋ฆฝํŠธ ์ตœ์‹  ์ฝ”๋“œ ๋™๊ธฐํ™” #427

Merged
merged 5 commits into from
Mar 6, 2024

Conversation

baekteun
Copy link
Member

@baekteun baekteun commented Mar 3, 2024

๐Ÿ’ก ๋ฐฐ๊ฒฝ ๋ฐ ๊ฐœ์š”

#419
ํ•ด๋‹น ์ž‘์—…์„ ์ง„ํ–‰ํ•˜๋ฉฐ Project๋ฅผ ์ •์˜ํ•˜๋Š” ์Šˆ๊ฐ€ ๋ฉ”์„œ๋“œ๊ฐ€ ๊ธฐ์กด์˜ ๋ฉ”์„œ๋“œ๋Š” deprecated๋˜๊ณ  ์ƒˆ๋กœ์šด ๋ฉ”์„œ๋“œ๋ฅผ ์‚ฌ์šฉํ•˜๋„๋ก ๋ณ€๊ฒฝ๋˜์—ˆ์–ด์š”.
์ƒˆ๋กญ๊ฒŒ ์‚ฌ์šฉํ•˜๋Š” ๋ฉ”์„œ๋“œ๋ฅผ ๊ธฐ์ค€์œผ๋กœ Project.swift๋ฅผ ์ •์˜ํ•˜์—ฌ ๋ชจ๋“ˆ์„ ๋งŒ๋“ค ์ˆ˜ ์žˆ๋Š” ์Šคํฌ๋ฆฝํŠธ๋ฅผ ๋งŒ๋“ค์–ด์š”.
๋”ํ•ด์„œ ๊ธฐ์กด์˜ feature ์ƒ์„ฑ ์Šคํฌ๋ฆฝํŠธ๋Š” feature ๋ ˆ์ด์–ด์—๋งŒ ํ•œ์ •ํ•˜์—ฌ ์‚ฌ์šฉํ•  ์ˆ˜ ์žˆ์ง€๋งŒ, ๋‹ค๋ฅธ ๋ ˆ์ด์–ด์—์„œ๋„ ์ถ”๊ฐ€๋กœ ๋งŒ๋“ค ์ˆ˜ ์žˆ๋„๋ก ๊ธฐ๋Šฅ์„ ํ™•์žฅํ–ˆ์–ด์š”.

Resolves: #424

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

  • ๋ชจ๋“ˆ ์ƒ์„ฑ ์Šคํฌ๋ฆฝํŠธ ์ž‘์„ฑ (Swift)
    • ๋ชจ๋“ˆ ๋ ˆ์ด์–ด ์ž…๋ ฅ
    • ๋ชจ๋“ˆ ์ด๋ฆ„ ์ž…๋ ฅ
    • ๋ชจ๋“ˆ์ด ๊ฐ€์ง„ Target ์ž…๋ ฅ (Interface, Source{Implementation}, Testing, UnitTests, UITests, Demo)
    • ์œ„ ์ž…๋ ฅ์„ ํ•œ ํ›„ ์ƒˆ๋กœ์šด ๋ชจ๋“ˆ์„ ๋งŒ๋“ค์–ด์š”
      • ModulePaths์— ์ƒˆ ๋ชจ๋“ˆ case ์ถ”๊ฐ€
      • ์‹ค์ œ ๊ฒฝ๋กœ์— ํ•ด๋‹นํ•˜๋Š” ๊ณณ์— ๋ชจ๋“ˆ ๊ธฐ๋ณธ ํŒŒ์ผ ๋ฐ Project.swift ์ •์˜
  • make feature ๋ช…๋ น์–ด deprecate
  • make module ๋ช…๋ น์–ด ์ง€์›

๐Ÿ™‹โ€โ™‚๏ธ ๋ฆฌ๋ทฐ๋…ธํŠธ

์ƒˆ ๋ชจ๋“ˆ์„ ์ถ”๊ฐ€ํ•  ๋•Œ, ์ž…๋ ฅ์„ ํ•˜๋ผ๋Š” ๋ฌธ๊ตฌ๋ฅผ ํ•œ๊ตญ์–ด๋กœ ํ• ๊นŒ์š”? ๊ตณ์ด ์˜์–ด๋กœ ํ•  ํ•„์š”์„ฑ์„ ๋ชป๋Š๊ปด์„œ ์–ด๋–ป๊ฒŒ ์ƒ๊ฐํ•˜์‹œ๋Š”์ง€ ๊ถ๊ธˆํ•ด์š” :)

โœ… PR ์ฒดํฌ๋ฆฌ์ŠคํŠธ

  • ์ด ์ž‘์—…์œผ๋กœ ์ธํ•ด ๋ณ€๊ฒฝ์ด ํ•„์š”ํ•œ ๋ฌธ์„œ๊ฐ€ ๋ณ€๊ฒฝ๋˜์—ˆ๋‚˜์š”? (e.g. XCConfig, ๋…ธ์…˜, README)
  • ์ด ์ž‘์—…์„ ํ•˜๊ณ ๋‚˜์„œ ๊ณต์œ ํ•ด์•ผํ•  ํŒ€์›๋“ค์—๊ฒŒ ๊ณต์œ ๋˜์—ˆ๋‚˜์š”? (e.g. "API ๊ฐœ๋ฐœ ์™„๋ฃŒ๋์–ด์š”", "XCConfig ๊ฐ’ ์ถ”๊ฐ€๋˜์—ˆ์–ด์š”")
  • ์ž‘์—…ํ•œ ์ฝ”๋“œ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ๋™์ž‘ํ•˜๋‚˜์š”?
  • Merge ๋Œ€์ƒ ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€์š”?
  • PR๊ณผ ๊ด€๋ จ ์—†๋Š” ์ž‘์—…์ด ์žˆ์ง€๋Š” ์•Š๋‚˜์š”?
  • ๋ชจ๋“ˆ ์ƒ์„ฑ ์Šคํฌ๋ฆฝํŠธ ๊ฐ€์ด๋“œ ๋ฌธ์„œ ์ž‘์„ฑ - ๋ฌธ์„œ

@baekteun baekteun added the โš™ Setting ๊ฐœ๋ฐœ ํ™˜๊ฒฝ ์„ธํŒ… label Mar 3, 2024
@baekteun baekteun self-assigned this Mar 3, 2024
Copy link

github-actions bot commented Mar 3, 2024

โœ… Successful finished SwiftLint

Copy link
Member

@yongbeomkwak yongbeomkwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์Šคํฌ๋ฆฝํŠธ ํ™•์ธํ–ˆ์Šต๋‹ˆ๋‹ค:)

@KangTaeHoon
Copy link
Contributor

ํ•œ๊ธ€ ์ข‹์Šต๋‹ˆ๋‹ค.

Base automatically changed from feature/424-template-plugin to develop March 6, 2024 06:28
@baekteun baekteun force-pushed the feature/424-module-generate-script-sync branch from 2614665 to fef804e Compare March 6, 2024 06:32
@baekteun baekteun merged commit 2ba7012 into develop Mar 6, 2024
3 checks passed
@baekteun baekteun deleted the feature/424-module-generate-script-sync branch March 6, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
โš™ Setting ๊ฐœ๋ฐœ ํ™˜๊ฒฝ ์„ธํŒ…
Projects
None yet
3 participants