Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ”€ :: (#472) 도메인 λͺ¨λ“ˆ 뢄리 μž‘μ—… κ°„ λˆ„λ½λœ μ˜μ‘΄μ„± μΆ”κ°€ 2t #473

Merged
merged 1 commit into from
Mar 12, 2024
Merged

πŸ”€ :: (#472) 도메인 λͺ¨λ“ˆ 뢄리 μž‘μ—… κ°„ λˆ„λ½λœ μ˜μ‘΄μ„± μΆ”κ°€ 2t #473

merged 1 commit into from
Mar 12, 2024

Conversation

KangTaeHoon
Copy link
Contributor

πŸ’‘ λ°°κ²½ 및 κ°œμš”

도메인 λͺ¨λ“ˆ 뢄리 μž‘μ—… κ°„ λˆ„λ½λœ μ˜μ‘΄μ„± μΆ”κ°€ 2번 μ§Έ μ‹œλ„

Resolves: #472

πŸ“ƒ μž‘μ—…λ‚΄μš©

  • BaseDomainInterface > ThirdPartyLib 의쑴
  • ooDomainInterface > BaseDomainInterface 의쑴
  • PlayListDomainInterface > SongsDomainInterface 의쑴

πŸ™‹β€β™‚οΈ λ¦¬λ·°λ…ΈνŠΈ

이게 클린을 ν•˜κ³  λΉŒλ“œλŒλ €λ„ ν•œ λ²ˆμ— μ—λŸ¬κ°€ μ•ˆλ‚˜μ˜€λŠ”κ²Œ λ„ˆλ¬΄ 함정인듯.. :(

image

βœ… PR 체크리슀트

ν…œν”Œλ¦Ώ 체크리슀트 말고도 μΆ”κ°€μ μœΌλ‘œ ν•„μš”ν•œ μ²΄ν¬λ¦¬μŠ€νŠΈλŠ” μΆ”κ°€ν•΄μ£Όμ„Έμš”!

  • 이 μž‘μ—…μœΌλ‘œ 인해 변경이 ν•„μš”ν•œ λ¬Έμ„œκ°€ λ³€κ²½λ˜μ—ˆλ‚˜μš”? (e.g. XCConfig, λ…Έμ…˜, README)
  • 이 μž‘μ—…μ„ ν•˜κ³ λ‚˜μ„œ κ³΅μœ ν•΄μ•Όν•  νŒ€μ›λ“€μ—κ²Œ κ³΅μœ λ˜μ—ˆλ‚˜μš”? (e.g. "API 개발 μ™„λ£Œλμ–΄μš”", "XCConfig κ°’ μΆ”κ°€λ˜μ—ˆμ–΄μš”")
  • μž‘μ—…ν•œ μ½”λ“œκ°€ μ •μƒμ μœΌλ‘œ λ™μž‘ν•˜λ‚˜μš”?
  • Merge λŒ€μƒ λΈŒλžœμΉ˜κ°€ μ˜¬λ°”λ₯Έκ°€μš”?
  • PRκ³Ό κ΄€λ ¨ μ—†λŠ” μž‘μ—…μ΄ μžˆμ§€λŠ” μ•Šλ‚˜μš”?

🎸 기타

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 11, 2024 •
edited
Loading

βœ… Successful finished SwiftLint

@github-actions github-actions bot added 0️⃣ Priority: Critical μš°μ„ μˆœμœ„ κΈ΄κΈ‰ 🐞 Bug 버그 κ΄€λ ¨ labels Mar 11, 2024
@github-actions GitHub Actions
Copy link

βœ… μ΄μŠˆμ™€ PR의 Labels 동기화λ₯Ό μ„±κ³΅ν–ˆμ–΄μš”!

@KangTaeHoon KangTaeHoon merged commit 5fb74bf into develop Mar 12, 2024
5 checks passed
@KangTaeHoon KangTaeHoon deleted the fix/472-add-dependency-2t branch March 12, 2024 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baekteun baekteun baekteun approved these changes

@yongbeomkwak yongbeomkwak yongbeomkwak approved these changes

@kimdaehee0824 kimdaehee0824 Awaiting requested review from kimdaehee0824 kimdaehee0824 is a code owner

@youn9k youn9k Awaiting requested review from youn9k youn9k is a code owner

Assignees

@KangTaeHoon KangTaeHoon

Labels
0️⃣ Priority: Critical μš°μ„ μˆœμœ„ κΈ΄κΈ‰ 🐞 Bug 버그 κ΄€λ ¨
Projects
None yet
Milestone
No milestone
3 participants
@KangTaeHoon @yongbeomkwak @baekteun