Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ”€ :: (#515) ๊ณตํ†ต ํŒ์—…์„ Interface๋กœ ๋บ๋‹ˆ๋‹ค. #518

Merged
merged 71 commits into from
May 5, 2024

Conversation

yongbeomkwak
Copy link
Member

๐Ÿ’ก ๋ฐฐ๊ฒฝ ๋ฐ ๊ฐœ์š”

ํ…์ŠคํŠธ ํŒ์—…์ด ๋งŽ์€ ๊ณก์—์„œ ์‚ฌ์šฉ ์ค‘์ธ๋ฐ Feature์— ์ง์ ‘ ์ ‘๊ทผํ•ด์„œ VC๋ฅผ ๋งŒ๋“ญ๋‹ˆ๋‹ค.

Resolves: #515

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

  • TextPopUpVC๋ฅผ ์‚ฌ์šฉ ์ค‘์ธ ๊ณณ์„ ํŒฉํ† ๋ฆฌ๋ฅผ ํ†ตํ•ด Feature๊ฐ€ ์•„๋‹Œ interface๋กœ ์ ‘๊ทผํ•˜๊ฒŒ ๋ฐ”๊ฟจ์Šต๋‹ˆ๋‹ค.

๐Ÿ™‹โ€โ™‚๏ธ ๋ฆฌ๋ทฐ๋…ธํŠธ

๊ตฌํ˜„ ์‹œ์— ๊ณ ๋ฏผ์ด์—ˆ๋˜ ์ ๋“ค ํ˜น์€ ํŠน์ • ๋ถ€๋ถ„์— ๋Œ€ํ•œ ์˜๋„๊ฐ€ ์žˆ์—ˆ๋‹ค๋ฉด PR ๋ฆฌ๋ทฐ์˜ ์ดํ•ด๋ฅผ ๋•๊ธฐ ์œ„ํ•ด ์„œ์ˆ ํ•ด์ฃผ์„ธ์š”!
์ผ๋‹จ ๊ต์ฒด๋งŒ ์‹œ์ผœ ๋†“์€ ์ƒํƒœ, ๋‹ค๋ฅธ ํ™”๋ฉด๋“ค ๊ตฌ์กฐ๋ฅผ ๋ฆฌํŒฉํ•˜๋ฉด์„œ ๋ถ„๋ช…ํžˆ ์ˆ˜์ •์ด ํ•„์š”ํ•จ
๋˜ํ•œ ๋ฆฌ๋ทฐ์–ด์—๊ฒŒ ํŠน์ • ๋ถ€๋ถ„์— ๋Œ€ํ•œ ์ง‘์ค‘ ํ˜น์€ ์ฝ”๋ฉ˜ํŠธ ํ˜น์€ ์งˆ๋ฌธ์„ ์š”์ฒญํ•˜๋Š” ๊ฒฝ์šฐ์— ์ž‘์„ฑํ•˜๋ฉด ์ข‹์•„์š”!

e.g. ์ž‘์—…์„ ๋๋‚ด์•ผํ•  ์‹œ๊ฐ„์ด ์–ผ๋งˆ ์—†์–ด ํ™•์žฅ์„ฑ๋ณด๋‹ค๋Š” ๋™์ž‘์„ ์œ„์ฃผ๋กœ ๋งŒ๋“ค์—ˆ์–ด์š”! ๊ฐ์•ˆํ•˜๊ณ  ๋ฆฌ๋ทฐํ•ด์ฃผ์„ธ์š”!

โœ… PR ์ฒดํฌ๋ฆฌ์ŠคํŠธ

ํ…œํ”Œ๋ฆฟ ์ฒดํฌ๋ฆฌ์ŠคํŠธ ๋ง๊ณ ๋„ ์ถ”๊ฐ€์ ์œผ๋กœ ํ•„์š”ํ•œ ์ฒดํฌ๋ฆฌ์ŠคํŠธ๋Š” ์ถ”๊ฐ€ํ•ด์ฃผ์„ธ์š”!

  • ์ด ์ž‘์—…์œผ๋กœ ์ธํ•ด ๋ณ€๊ฒฝ์ด ํ•„์š”ํ•œ ๋ฌธ์„œ๊ฐ€ ๋ณ€๊ฒฝ๋˜์—ˆ๋‚˜์š”? (e.g. XCConfig, ๋…ธ์…˜, README)
  • ์ด ์ž‘์—…์„ ํ•˜๊ณ ๋‚˜์„œ ๊ณต์œ ํ•ด์•ผํ•  ํŒ€์›๋“ค์—๊ฒŒ ๊ณต์œ ๋˜์—ˆ๋‚˜์š”? (e.g. "API ๊ฐœ๋ฐœ ์™„๋ฃŒ๋์–ด์š”", "XCConfig ๊ฐ’ ์ถ”๊ฐ€๋˜์—ˆ์–ด์š”")
  • ์ž‘์—…ํ•œ ์ฝ”๋“œ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ๋™์ž‘ํ•˜๋‚˜์š”?
  • Merge ๋Œ€์ƒ ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€์š”?
  • PR๊ณผ ๊ด€๋ จ ์—†๋Š” ์ž‘์—…์ด ์žˆ์ง€๋Š” ์•Š๋‚˜์š”?

๐ŸŽธ ๊ธฐํƒ€

  • ๊ต์ฒด๋งŒ ํ•ด๋†จ์Šต๋‹ˆ๋‹ค.

yongbeomkwak and others added 30 commits May 4, 2024 16:29
โ€ฆailReactor.swift

Co-authored-by: baegteun <baegteun@gmail.com>
Copy link

github-actions bot commented May 4, 2024

โœ… Assign ์ž๋™ ์ง€์ •์„ ์„ฑ๊ณตํ–ˆ์–ด์š”!

@yongbeomkwak

yongbeomkwak and others added 3 commits May 5, 2024 00:30
โ€ฆListDetailViewController.swift

Co-authored-by: Youngkyu Song <ace_lephant@naver.com>
โ€ฆListDetailViewController.swift

Co-authored-by: Youngkyu Song <ace_lephant@naver.com>
โ€ฆListDetailViewController.swift

Co-authored-by: Youngkyu Song <ace_lephant@naver.com>
@yongbeomkwak yongbeomkwak changed the title ใ…‡ ๐Ÿ”€ :: (#515) ๊ณตํ†ต ํŒ์—…์„ Interface๋กœ ๋บ๋‹ˆ๋‹ค. May 4, 2024
yongbeomkwak and others added 20 commits May 5, 2024 12:54
๐Ÿ”€ :: (#492) PlaylistDetail์„ ReactorKit์œผ๋กœ ๋ฆฌํŒฉํ•ฉ๋‹ˆ๋‹ค.
@yongbeomkwak yongbeomkwak merged commit 407642c into develop May 5, 2024
3 checks passed
@yongbeomkwak yongbeomkwak deleted the 515-seperate-commonUI-by-interface branch May 5, 2024 06:51
@youn9k
Copy link
Member

youn9k commented May 5, 2024

ํŒฉํ† ๋ฆฌํŒจํ„ด์„ ์จ๋ณธ์ ์ด ์—†์–ด์„œ ๊ธฐ์กด ์ฝ”๋“œ๋ž‘ ๋น„๊ตํ–ˆ์„ ๋•Œ ์–ด๋–ค ์žฅ์ ์ด ์žˆ๋‚˜์š”?

@yongbeomkwak
Copy link
Member Author

๋‹ค์–‘ํ•œ ํ“จ์ฒ˜์—์„œ ์“ฐ๋ฉด ํ“จ์ฒ˜๋ฅผ ์ง์ ‘ ์ ‘๊ทผํ•˜์ง€ ์•Š๊ณ  interface์— ์ ‘๊ทผํ•˜๊ฒŒ ํ•ด์„œ ์˜์กด๋„๋ฅผ ๋–จ์–ดํŠธ๋ฆฌ๋Š”๋ฐ์š”
์ด ๋•Œ VC์— ์ง์ ‘ ์ ‘๊ทผํ•˜๋Š”๊ฒŒ ์•„๋‹ˆ๋ผ interface์—์„œ ํ”„๋กœํ† ์ฝœ์— ์ ‘๊ทผํ•ด์„œ ์ƒ์„ฑํ•˜๊ฒŒ ํ•˜๋Š”๊ฑฐ์—์—ฌ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

๊ณตํ†ต ํŒ์—…์„ Interface๋กœ ๋นผ๊ธฐ
2 participants