Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ”€ :: (#569) μ„€μ • ν™”λ©΄ μ»΄ν¬λ„ŒνŠΈλ₯Ό Stub ν•˜κΈ° μœ„ν•œ λ‚΄λΆ€ λͺ¨λ“ˆ Stub #580

Merged
merged 9 commits into from
Jun 11, 2024
Merged

πŸ”€ :: (#569) μ„€μ • ν™”λ©΄ μ»΄ν¬λ„ŒνŠΈλ₯Ό Stub ν•˜κΈ° μœ„ν•œ λ‚΄λΆ€ λͺ¨λ“ˆ Stub #580

merged 9 commits into from
Jun 11, 2024

Conversation

youn9k
Copy link
Member

@youn9k youn9k commented Jun 6, 2024 •
edited
Loading

πŸ’‘ λ°°κ²½ 및 κ°œμš”

μ„€μ •ν™”λ©΄μ˜ Stub을 λ§Œλ“€κΈ° μœ„ν•œ λ‚΄λΆ€ λͺ¨λ“ˆλ“€μ˜ Stub 객체λ₯Ό 생성해야 ν–ˆμŠ΅λ‹ˆλ‹€.

Resolves: #569

πŸ“ƒ μž‘μ—…λ‚΄μš©

  • MyInfoFeature λ‚΄λΆ€ μ»΄ν¬λ„ŒνŠΈλ“€μ— λŒ€ν•œ Stub 객체λ₯Ό μƒμ„±ν–ˆμŠ΅λ‹ˆλ‹€.
  • μ„€μ •ν™”λ©΄ μ»΄ν¬λ„ŒνŠΈμ— λŒ€ν•œ Stub 객체λ₯Ό μƒμ„±ν–ˆμŠ΅λ‹ˆλ‹€.

πŸ™‹β€β™‚οΈ λ¦¬λ·°λ…ΈνŠΈ

SettingComponentStub 은 Testing λͺ¨λ“ˆμ— 있고,
Testingλͺ¨λ“ˆμ€ Featureλ₯Ό λͺ¨λ₯΄κΈ° λ•Œλ¬Έμ— SettingViewController 에 Cannot find 'SettingViewController' in scope μ—λŸ¬κ°€ λ°œμƒν–ˆμŠ΅λ‹ˆλ‹€. 이에 λŒ€ν•œ ν•΄κ²°λ²•μœΌλ‘œ

  1. Testing λͺ¨λ“ˆμ— Feature μ˜μ‘΄μ„±μ„ μΆ”κ°€ν•œλ‹€.
  2. λͺ¨λ“  ViewController, Reactor λ₯Ό 각 ~ViewControllerType, ~ReactorType ν”„λ‘œν† μ½œμ„ μΈν„°νŽ˜μ΄μŠ€ λͺ¨λ“ˆμ— λ§Œλ“€μ–΄ μ±„νƒν•˜λ„λ‘ ν•œλ‹€.

λ‘˜ 쀑 μ½”μŠ€νŠΈκ°€ 더 적은 1번 방법을 μ‚¬μš©ν–ˆμŠ΅λ‹ˆλ‹€.

βœ… PR 체크리슀트

  • 이 μž‘μ—…μœΌλ‘œ 인해 변경이 ν•„μš”ν•œ λ¬Έμ„œκ°€ λ³€κ²½λ˜μ—ˆλ‚˜μš”? (e.g. XCConfig, λ…Έμ…˜, README)
  • 이 μž‘μ—…μ„ ν•˜κ³ λ‚˜μ„œ κ³΅μœ ν•΄μ•Όν•  νŒ€μ›λ“€μ—κ²Œ κ³΅μœ λ˜μ—ˆλ‚˜μš”? (e.g. "API 개발 μ™„λ£Œλμ–΄μš”", "XCConfig κ°’ μΆ”κ°€λ˜μ—ˆμ–΄μš”")
  • μž‘μ—…ν•œ μ½”λ“œκ°€ μ •μƒμ μœΌλ‘œ λ™μž‘ν•˜λ‚˜μš”?
  • Merge λŒ€μƒ λΈŒλžœμΉ˜κ°€ μ˜¬λ°”λ₯Έκ°€μš”?
  • PRκ³Ό κ΄€λ ¨ μ—†λŠ” μž‘μ—…μ΄ μžˆμ§€λŠ” μ•Šλ‚˜μš”?

🎸 기타

img
μœ„λŠ” 정석적인 TMA λͺ¨λ“ˆ 의쑴 ꡬ쑰

youn9k added 9 commits June 6, 2024 11:59
@youn9k youn9k added the βœ… Test Test κ΄€λ ¨ label Jun 6, 2024
@github-actions github-actions bot added the ♻️ Refactor μ½”λ“œ λ¦¬νŒ©ν† λ§ label Jun 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2024 •
edited
Loading

βœ… Successful finished SwiftLint

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2024

βœ… Assign μžλ™ 지정을 μ„±κ³΅ν–ˆμ–΄μš”!

@youn9k

@youn9k youn9k linked an issue Jun 6, 2024 that may be closed by this pull request
μ„€μ •ν™”λ©΄ Stub #569
Closed
4 tasks
Base automatically changed from feature/569-setting-factory-stub to develop June 11, 2024 08:51
@youn9k youn9k merged commit 9ae82bf into develop Jun 11, 2024
3 checks passed
@youn9k youn9k deleted the 569-setting-factory-stub/internal-stub branch June 11, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yongbeomkwak yongbeomkwak yongbeomkwak approved these changes

@KangTaeHoon KangTaeHoon KangTaeHoon approved these changes

@kimdaehee0824 kimdaehee0824 Awaiting requested review from kimdaehee0824 kimdaehee0824 is a code owner

@baekteun baekteun Awaiting requested review from baekteun baekteun is a code owner

Assignees

@youn9k youn9k

Labels
♻️ Refactor μ½”λ“œ λ¦¬νŒ©ν† λ§ βœ… Test Test κ΄€λ ¨
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

μ„€μ •ν™”λ©΄ Stub
3 participants
@youn9k @KangTaeHoon @yongbeomkwak