Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Migrate to use proto files from common proto repo for all Waku protocols #720

Closed
chaitanyaprem opened this issue Sep 8, 2023 · 0 comments · Fixed by #828
Closed
Assignees

Comments

@chaitanyaprem
Copy link
Collaborator

chaitanyaprem commented Sep 8, 2023

Background

As of now, Waku protocol proto files are duplicated in go-waku repo from https://github.com/waku-org/waku-proto and then the code is generated from them to use. This causes trouble because we need to keep track of reference proto file and its changes and manually diff and apply changes when a new version is created.
This process would be errorprone.
Instead, once proto files are migrated to waku-org repo, generate all protobuf code from those proto files by making that repo a sub-module of go-waku repo.

Details

Note: Original proto files may have different package convention than what is used in go-waku, hence protogen command takes a flag which can specify the package to be used for the generated code.

Acceptance criteria

Need to make sure all unit tests pass.
Ensure interop tests with nwaku also pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants