chore: use waku-org/waku-proto repository for protobuffer definitions #828

richard-ramos · 2023-10-24T16:24:46Z

Description

This PR removes the .proto files from the repository and adds waku-proto
as a submodule to be used to generate the protobuffer bindings in go

Changes

Depends on: waku-org/waku-proto#19

Issue

closes #720

status-im-auto · 2023-10-24T16:26:19Z

Jenkins Builds

Click to see older builds (65)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✖️	`3ed204f`	#1	2023-10-24 16:26:18	~1 min	`nix-flake`	📄`log`
✔️	`3ed204f`	#1	2023-10-24 16:28:44	~3 min	`linux`	📦`deb`
✔️	`3ed204f`	#1	2023-10-24 16:29:19	~4 min	`android`	📦`tgz`
✖️	`3ed204f`	#1	2023-10-24 16:30:55	~5 min	`tests`	📄`log`
✔️	`3ed204f`	#1	2023-10-24 16:30:59	~5 min	`ios`	📦`tgz`
✖️	`3ed204f`	#1	2023-10-24 16:31:40	~6 min	`tests`	📄`log`

❌	`b85f1b7`	#2	2023-10-25 15:12:39	~2 min	`linux`	📄`log`
✔️	`b85f1b7`	#2	2023-10-25 15:13:50	~4 min	`android`	📦`tgz`
✔️	`b85f1b7`	#2	2023-10-25 15:13:57	~4 min	`ios`	📦`tgz`
✔️	`b85f1b7`	#2	2023-10-25 15:14:31	~4 min	`nix-flake`	📄`log`
✔️	`b85f1b7`	#2	2023-10-25 15:17:03	~7 min	`tests`	📄`log`
✔️	`b85f1b7`	#2	2023-10-25 15:17:11	~7 min	`tests`	📄`log`

❌	`ff79f69`	#3	2023-10-25 15:45:34	~31 sec	`linux`	📄`log`
✔️	`ff79f69`	#3	2023-10-25 15:46:55	~1 min	`nix-flake`	📄`log`
✔️	`ff79f69`	#3	2023-10-25 15:47:25	~2 min	`tests`	📄`log`
✔️	`ff79f69`	#3	2023-10-25 15:48:45	~3 min	`android`	📦`tgz`
✔️	`ff79f69`	#3	2023-10-25 15:48:52	~3 min	`tests`	📄`log`
✔️	`ff79f69`	#3	2023-10-25 15:49:25	~4 min	`ios`	📦`tgz`

✔️	`972379b`	#4	2023-10-25 16:01:51	~1 min	`nix-flake`	📄`log`
✔️	`972379b`	#4	2023-10-25 16:02:15	~2 min	`linux`	📦`deb`
✔️	`972379b`	#4	2023-10-25 16:02:18	~2 min	`tests`	📄`log`
✔️	`972379b`	#4	2023-10-25 16:03:38	~3 min	`android`	📦`tgz`
✔️	`972379b`	#4	2023-10-25 16:03:43	~3 min	`ios`	📦`tgz`
✖️	`972379b`	#4	2023-10-25 16:05:44	~5 min	`tests`	📄`log`
✔️	`972379b`	#5	2023-10-25 16:11:04	~3 min	`tests`	📄`log`
✔️	`972379b`	#6	2023-10-25 17:57:51	~1 min	`tests`	📄`log`
✔️	`972379b`	#7	2023-10-25 18:02:27	~1 min	`tests`	📄`log`

✔️	`5b08a17`	#5	2023-10-26 00:54:45	~1 min	`linux`	📦`deb`
✔️	`5b08a17`	#5	2023-10-26 00:55:01	~1 min	`nix-flake`	📄`log`
✔️	`5b08a17`	#8	2023-10-26 00:55:03	~1 min	`tests`	📄`log`
✔️	`5b08a17`	#5	2023-10-26 00:56:24	~3 min	`tests`	📄`log`
✔️	`5b08a17`	#5	2023-10-26 00:57:26	~4 min	`android`	📦`tgz`
✔️	`5b08a17`	#5	2023-10-26 00:57:58	~4 min	`ios`	📦`tgz`

✖️	`6850cdd`	#9	2023-10-30 18:09:39	~25 sec	`tests`	📄`log`
✖️	`6850cdd`	#6	2023-10-30 18:09:40	~25 sec	`tests`	📄`log`
❌	`6850cdd`	#6	2023-10-30 18:09:59	~48 sec	`linux`	📄`log`
✔️	`6850cdd`	#6	2023-10-30 18:11:09	~1 min	`nix-flake`	📄`log`
✔️	`6850cdd`	#6	2023-10-30 18:13:00	~3 min	`android`	📦`tgz`
✔️	`6850cdd`	#6	2023-10-30 18:20:49	~11 min	`ios`	📦`tgz`

❌	`91ec1b0`	#7	2023-10-30 18:14:28	~43 sec	`linux`	📄`log`
✔️	`91ec1b0`	#7	2023-10-30 18:15:37	~1 min	`nix-flake`	📄`log`
✔️	`91ec1b0`	#10	2023-10-30 18:15:40	~1 min	`tests`	📄`log`
✔️	`91ec1b0`	#7	2023-10-30 18:17:00	~3 min	`tests`	📄`log`
✔️	`91ec1b0`	#7	2023-10-30 18:17:14	~3 min	`android`	📦`tgz`
✔️	`91ec1b0`	#7	2023-10-30 18:32:25	~18 min	`ios`	📦`tgz`

✔️	`e3fcc97`	#8	2023-10-30 19:15:57	~1 min	`linux`	📦`deb`
✔️	`e3fcc97`	#8	2023-10-30 19:16:06	~1 min	`nix-flake`	📄`log`
✔️	`e3fcc97`	#11	2023-10-30 19:16:12	~1 min	`tests`	📄`log`
✔️	`e3fcc97`	#8	2023-10-30 19:17:58	~3 min	`android`	📦`tgz`
✖️	`e3fcc97`	#8	2023-10-30 19:19:46	~5 min	`tests`	📄`log`
✔️	`e3fcc97`	#8	2023-10-30 19:31:42	~17 min	`ios`	📦`tgz`
✖️	`e3fcc97`	#9	2023-10-30 19:57:26	~59 sec	`tests`	📄`log`
✔️	`e3fcc97`	#10	2023-10-30 19:59:44	~2 min	`tests`	📄`log`

✖️	`2574cc8`	#11	2023-11-02 15:43:35	~23 sec	`tests`	📄`log`
✖️	`2574cc8`	#12	2023-11-02 15:43:38	~26 sec	`tests`	📄`log`
✔️	`2574cc8`	#9	2023-11-02 15:44:18	~1 min	`linux`	📦`deb`
✔️	`2574cc8`	#9	2023-11-02 15:45:07	~1 min	`nix-flake`	📄`log`
✔️	`2574cc8`	#9	2023-11-02 15:47:08	~4 min	`android`	📦`tgz`
✔️	`2574cc8`	#9	2023-11-02 16:11:01	~27 min	`ios`	📦`tgz`

✔️	`51b6546`	#10	2023-11-03 14:04:10	~3 min	`ios`	📦`tgz`
✔️	`51b6546`	#10	2023-11-03 14:05:18	~5 min	`nix-flake`	📄`log`
✔️	`51b6546`	#10	2023-11-03 14:06:09	~5 min	`linux`	📦`deb`
✔️	`51b6546`	#13	2023-11-03 14:07:31	~7 min	`tests`	📄`log`
✔️	`51b6546`	#12	2023-11-03 14:08:10	~7 min	`tests`	📄`log`
✔️	`51b6546`	#10	2023-11-03 14:10:33	~10 min	`android`	📦`tgz`

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`26a51da`	#11	2023-11-03 15:11:48	~3 min	`ios`	📦`tgz`
✔️	`26a51da`	#14	2023-11-03 15:12:42	~4 min	`tests`	📄`log`
✔️	`26a51da`	#11	2023-11-03 15:12:44	~4 min	`nix-flake`	📄`log`
✔️	`26a51da`	#11	2023-11-03 15:12:46	~4 min	`linux`	📦`deb`
✔️	`26a51da`	#11	2023-11-03 15:14:14	~6 min	`android`	📦`tgz`
✔️	`26a51da`	#13	2023-11-03 15:14:16	~6 min	`tests`	📄`log`

✔️	`7c22c09`	#12	2023-11-07 19:41:30	~1 min	`linux`	📦`deb`
✔️	`7c22c09`	#12	2023-11-07 19:41:35	~1 min	`nix-flake`	📄`log`
✔️	`7c22c09`	#15	2023-11-07 19:41:53	~2 min	`tests`	📄`log`
✔️	`7c22c09`	#12	2023-11-07 19:43:35	~3 min	`android`	📦`tgz`
✔️	`7c22c09`	#12	2023-11-07 19:43:48	~4 min	`ios`	📦`tgz`
✖️	`7c22c09`	#14	2023-11-07 19:45:28	~5 min	`tests`	📄`log`
✔️	`7c22c09`	#15	2023-11-07 19:48:28	~2 min	`tests`	📄`log`

cmd/waku/server/rpc/relay.go

cmd/waku/server/rpc/filter.go

library/Create multiple nodes1

waku/v2/protocol/filter/pb/filter.pb.go

waku/v2/protocol/pb/waku_message.proto

cmd/waku/server/rpc/relay.go

library/encoding.go

waku/v2/protocol/rln/pb/rln.pb.go

waku/v2/protocol/pb/message.pb.go

waku/v2/protocol/noise/payload.go

chaitanyaprem

LGTM
Can be merged if protoc version is fixed.

github-actions bot assigned richard-ramos Oct 24, 2023

richard-ramos force-pushed the protobuf branch from 3ed204f to b85f1b7 Compare October 25, 2023 15:09

richard-ramos marked this pull request as ready for review October 25, 2023 15:10

richard-ramos requested a review from chaitanyaprem as a code owner October 25, 2023 15:10

richard-ramos requested a review from harsh-98 October 25, 2023 15:10

richard-ramos force-pushed the protobuf branch 2 times, most recently from ff79f69 to 972379b Compare October 25, 2023 15:59

chaitanyaprem reviewed Oct 25, 2023

View reviewed changes

richard-ramos force-pushed the protobuf branch 2 times, most recently from 6850cdd to 91ec1b0 Compare October 30, 2023 18:13

richard-ramos requested a review from chaitanyaprem October 30, 2023 19:08

richard-ramos force-pushed the protobuf branch from 91ec1b0 to e3fcc97 Compare October 30, 2023 19:13

chaitanyaprem reviewed Nov 2, 2023

View reviewed changes

richard-ramos force-pushed the protobuf branch 2 times, most recently from 2574cc8 to 51b6546 Compare November 3, 2023 13:59

chaitanyaprem approved these changes Nov 3, 2023

View reviewed changes

richard-ramos added 2 commits November 7, 2023 14:53

chore: use waku-org/waku-proto repository for protobuffer definitions

216a44e

fix: code review

7c22c09

richard-ramos force-pushed the protobuf branch from 26a51da to 7c22c09 Compare November 7, 2023 19:39

richard-ramos merged commit 150ade6 into master Nov 7, 2023
10 of 11 checks passed

richard-ramos deleted the protobuf branch November 7, 2023 19:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: use waku-org/waku-proto repository for protobuffer definitions #828

chore: use waku-org/waku-proto repository for protobuffer definitions #828

richard-ramos commented Oct 24, 2023 •

edited

Loading

status-im-auto commented Oct 24, 2023 •

edited

Loading

chaitanyaprem left a comment

chore: use waku-org/waku-proto repository for protobuffer definitions #828

chore: use waku-org/waku-proto repository for protobuffer definitions #828

Conversation

richard-ramos commented Oct 24, 2023 • edited Loading

Description

Changes

Issue

status-im-auto commented Oct 24, 2023 • edited Loading

Jenkins Builds

chaitanyaprem left a comment

Choose a reason for hiding this comment

richard-ramos commented Oct 24, 2023 •

edited

Loading

status-im-auto commented Oct 24, 2023 •

edited

Loading