fix(filter2): add requestID to pings and remove unneeded log

[richard-ramos]

Fixes this errors that appears on the fleet while doing a ping:

    "(kind: MissingRequiredField, field: "request_id")"
    Failed to decode filter subscribe request

[status-im-auto]

Jenkins Builds

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	dee77ba	#1	2023-09-26 16:08:32	~1 min	nix-flake	📄log
✔️	dee77ba	#1	2023-09-26 16:09:01	~2 min	linux	📦deb
✔️	dee77ba	#1	2023-09-26 16:09:52	~3 min	tests	📄log
✔️	dee77ba	#1	2023-09-26 16:09:56	~3 min	tests	📄log
✔️	dee77ba	#1	2023-09-26 16:10:30	~3 min	android	📦tgz
✔️	dee77ba	#1	2023-09-26 16:11:12	~4 min	ios	📦tgz
✔️	5446af9	#2	2023-09-26 16:17:59	~1 min	linux	📦deb
✔️	5446af9	#2	2023-09-26 16:18:27	~1 min	tests	📄log
✔️	5446af9	#2	2023-09-26 16:18:47	~1 min	nix-flake	📄log
✔️	5446af9	#2	2023-09-26 16:19:00	~2 min	tests	📄log
✔️	5446af9	#2	2023-09-26 16:20:23	~3 min	android	📦tgz
✔️	5446af9	#2	2023-09-26 16:21:01	~4 min	ios	📦tgz

[vitvly]

Great :)

[chaitanyaprem]

LGTM

Surprising that this did not get caught at protobuf level... probably because it is a string.

[richard-ramos]

it' because nwaku's is mixing protobuffer decoding with field validation:

• https://github.com/waku-org/nwaku/blob/master/waku/waku_filter_v2/rpc_codec.nim#L31-L53
• https://github.com/waku-org/nwaku/blob/3264a4f5877203ba085f1a4e8e02e4ffc6ce9249/waku/waku_filter_v2/protocol.nim#L228-L231 .
  IMO since the protobuffer request is valid, nwaku should evaluate if a field is required or not just like it is done here: https://github.com/waku-org/nwaku/blob/3264a4f5877203ba085f1a4e8e02e4ffc6ce9249/waku/waku_filter_v2/protocol.nim#L46-L50 and not fail silently