-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: filter select peer for sharding #783
Feat: filter select peer for sharding #783
Conversation
Jenkins BuildsClick to see older builds (18)
|
@SionoiS , I have noticed that in nwaku while selecting peers from serviceSlots the filtering is not done as per shards. JFYI in case it is not already being tracked. |
Ah! good catch I didn't notice that. Thanks! |
* feat: update lightpush API to make pubSubTopic optional as per autosharding * Extract contentFilter and subscriptions out of filter to reuse in relay (#779) * chore: extract contentFilter outside filter package * chore: move subscription outside of filter so that it can be modified and reused for relay * Feat: filter select peer for sharding (#783) * update selectPeer to support pubsubTopic based selection
Description
Current selectPeer functionality works without taking sharding into consideration. #680
This enhances to take pubSubTopic or contentTopic into consideration during peer selection.
Changes
Tests
Ran all existing unit tests.
Added few new ones to validate functionality.