Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SignalHandler not exported in mobile package #793

Merged
merged 3 commits into from
Oct 7, 2023

Conversation

richard-ramos
Copy link
Member

Description

During the library refactor, the mobile package ended up missing the SignalHandler. This PR adds it back to the correct folder

Issue

closes #790

@status-im-auto
Copy link

status-im-auto commented Oct 3, 2023

Jenkins Builds

Click to see older builds (6)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ e942694 #1 2023-10-03 23:45:42 ~2 min nix-flake 📄log
✔️ e942694 #1 2023-10-03 23:46:08 ~2 min linux 📦deb
✔️ e942694 #1 2023-10-03 23:46:28 ~2 min tests 📄log
✔️ e942694 #1 2023-10-03 23:47:32 ~4 min android 📦tgz
✔️ e942694 #1 2023-10-03 23:47:59 ~4 min tests 📄log
✔️ e942694 #1 2023-10-03 23:48:02 ~4 min ios 📦tgz
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 6170130 #2 2023-10-07 20:21:36 ~1 min tests 📄log
✔️ 6170130 #2 2023-10-07 20:21:56 ~1 min nix-flake 📄log
✔️ 6170130 #3 2023-10-07 20:22:12 ~13 sec nix-flake 📄log
✔️ 6170130 #2 2023-10-07 20:22:13 ~2 min tests 📄log
✔️ 6170130 #3 2023-10-07 20:22:26 ~46 sec tests 📄log
✔️ 6170130 #2 2023-10-07 20:22:29 ~2 min linux 📦deb
✔️ 6170130 #3 2023-10-07 20:23:27 ~53 sec linux 📦deb
✔️ 6170130 #2 2023-10-07 20:25:21 ~5 min ios 📦tgz
✔️ 6170130 #3 2023-10-07 20:25:22 ~5 min ios 📦tgz
✔️ 6170130 #3 2023-10-07 20:25:26 ~3 min tests 📄log
✔️ 6170130 #3 2023-10-07 20:27:19 ~3 min android 📦tgz
✔️ 7c8bc3a #2 2023-10-07 20:24:06 ~4 min android 📦tgz

Copy link
Collaborator

@chaitanyaprem chaitanyaprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richard-ramos richard-ramos merged commit e1417b3 into master Oct 7, 2023
11 checks passed
@richard-ramos richard-ramos deleted the fix/mobile-signal-handler branch October 7, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

bug: release 0.8.0 android library doesn't have type SignalHandler
3 participants