Feat : New Relay rest API for autosharding #822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (19)
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| err := r.node.Relay().Unsubscribe(req.Context(), protocol.NewContentFilter("", cTopics...)) | ||
| if err != nil { | ||
| r.log.Error("unsubscribing from topics", zap.Strings("contentTopics", cTopics), zap.Error(err)) |
Check failure
Code scanning / CodeQL
Log entries created from user input
3 tasks
harsh-98
suggested changes
Oct 21, 2023
richard-ramos
approved these changes
Oct 23, 2023
| var err error | ||
| _, err = r.node.Relay().Subscribe(r.node.Relay().Context(), protocol.NewContentFilter("", cTopics...)) | ||
| if err != nil { | ||
| r.log.Error("subscribing to topics", zap.Strings("contentTopics", cTopics), zap.Error(err)) |
Check failure
Code scanning / CodeQL
Log entries created from user input
|
|
||
| _, err = r.node.Relay().Publish(req.Context(), message) | ||
| if err != nil { | ||
| r.log.Error("publishing message", zap.Error(err)) |
Check failure
Code scanning / CodeQL
Log entries created from user input
|
@harsh-98 , can't merge this as you have requested changes. |
harsh-98
approved these changes
Oct 23, 2023
|
lgtm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added new REST relay APIs for autosharding.
Changes
Tests
Verified all new API's +ve and -ve scenarios by running a node locally and connecting another node.