Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: print a message periodically indicating that VACUUM is still being executed #838

Merged
merged 3 commits into from
Oct 30, 2023

Conversation

richard-ramos
Copy link
Member

Description

This will print every 2 minutes the following log line

2023-10-25T21:00:22.973-0400    INFO    gowaku.db-setup sqlite/sqlite.go:63     still vacuuming...      {"node": "16Uiu2HAmJikHbVZJhVtbCvXGwCb6sekZKkZcyP9uU7BcaaAeUWoN"}

It's dumb, but it's good UX to indicate that something is happening :)

@status-im-auto
Copy link

status-im-auto commented Oct 26, 2023

Jenkins Builds

Click to see older builds (6)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 5dcbeae #1 2023-10-26 01:05:28 ~1 min nix-flake 📄log
✖️ 5dcbeae #1 2023-10-26 01:06:09 ~2 min tests 📄log
✔️ 5dcbeae #1 2023-10-26 01:06:16 ~2 min linux 📦deb
✔️ 5dcbeae #1 2023-10-26 01:07:22 ~3 min tests 📄log
✔️ 5dcbeae #1 2023-10-26 01:07:42 ~4 min ios 📦tgz
✔️ 5dcbeae #1 2023-10-26 01:07:51 ~4 min android 📦tgz
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ d25e8f3 #2 2023-10-27 13:04:39 ~1 min linux 📦deb
✔️ d25e8f3 #2 2023-10-27 13:05:31 ~2 min nix-flake 📄log
✔️ d25e8f3 #2 2023-10-27 13:06:46 ~3 min tests 📄log
✔️ d25e8f3 #2 2023-10-27 13:06:57 ~3 min tests 📄log
✔️ d25e8f3 #2 2023-10-27 13:07:03 ~3 min android 📦tgz
✔️ d25e8f3 #2 2023-10-27 13:07:03 ~3 min ios 📦tgz
✔️ 21f2fbe #3 2023-10-30 12:51:34 ~2 min nix-flake 📄log
✔️ 21f2fbe #3 2023-10-30 12:51:54 ~2 min linux 📦deb
✔️ 21f2fbe #3 2023-10-30 12:53:00 ~3 min tests 📄log
✔️ 21f2fbe #3 2023-10-30 12:53:36 ~4 min ios 📦tgz
✔️ 21f2fbe #3 2023-10-30 12:53:44 ~4 min android 📦tgz
✔️ 21f2fbe #3 2023-10-30 12:54:47 ~5 min tests 📄log

Copy link
Member

@yakimant yakimant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I don't know Go much.

@richard-ramos richard-ramos merged commit 2797523 into master Oct 30, 2023
9 of 11 checks passed
@richard-ramos richard-ramos deleted the chore/vacuum-msg branch October 30, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants