Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rest-filterv2): get message #856

Merged
merged 9 commits into from
Nov 4, 2023
Merged

feat(rest-filterv2): get message #856

merged 9 commits into from
Nov 4, 2023

Conversation

harsh-98
Copy link
Contributor

@harsh-98 harsh-98 commented Nov 1, 2023

Description

Get messages endpoint. Related to: #746

Changes

  • add two endpoints based on discussion with richard.
  • add test

Tests

  • new and previous tets are passing.

@harsh-98 harsh-98 changed the base branch from master to SubMapEncapsulation November 1, 2023 15:27
@status-im-auto
Copy link

status-im-auto commented Nov 1, 2023

Jenkins Builds

Click to see older builds (40)
Commit #️⃣ Finished (UTC) Duration Platform Result
✖️ 0812969 #1 2023-11-01 15:29:08 ~1 min tests 📄log
✖️ 0812969 #1 2023-11-01 15:29:10 ~1 min tests 📄log
✔️ 0812969 #1 2023-11-01 15:29:33 ~2 min nix-flake 📄log
✔️ 0812969 #1 2023-11-01 15:30:00 ~2 min linux 📦deb
✖️ 0812969 #2 2023-11-01 15:31:24 ~2 min tests 📄log
✔️ 0812969 #1 2023-11-01 15:31:50 ~4 min android 📦tgz
✔️ 0812969 #2 2023-11-01 15:31:57 ~4 min ios 📦tgz
✔️ 0812969 #1 2023-11-01 15:32:08 ~4 min ios 📦tgz
✖️ 0812969 #2 2023-11-01 15:33:01 ~3 min tests 📄log
✔️ 0812969 #2 2023-11-01 15:33:44 ~4 min nix-flake 📄log
✔️ 0812969 #2 2023-11-01 15:34:01 ~3 min linux 📦deb
✔️ 0812969 #2 2023-11-01 15:37:16 ~5 min android 📦tgz
✔️ 4b6b08f #3 2023-11-01 15:48:01 ~1 min linux 📦deb
✔️ 4b6b08f #3 2023-11-01 15:48:49 ~1 min nix-flake 📄log
✖️ 4b6b08f #3 2023-11-01 15:49:21 ~2 min tests 📄log
✔️ 4b6b08f #3 2023-11-01 15:50:23 ~3 min android 📦tgz
✔️ 4b6b08f #3 2023-11-01 15:50:26 ~3 min ios 📦tgz
✔️ 4b6b08f #3 2023-11-01 15:50:45 ~3 min tests 📄log
✔️ 4b6b08f #4 2023-11-01 15:53:19 ~2 min tests 📄log
✖️ 273953d #4 2023-11-02 13:37:56 ~19 sec tests 📄log
✖️ 273953d #5 2023-11-02 13:37:57 ~21 sec tests 📄log
✖️ 273953d #4 2023-11-02 13:38:31 ~56 sec nix-flake 📄log
273953d #4 2023-11-02 13:38:36 ~1 min linux 📄log
✔️ 273953d #4 2023-11-02 13:40:53 ~3 min android 📦tgz
✔️ 273953d #4 2023-11-02 13:49:16 ~11 min ios 📦tgz
729af10 #5 2023-11-02 13:45:53 ~18 sec linux 📄log
✖️ 729af10 #5 2023-11-02 13:45:57 ~21 sec tests 📄log
✖️ 729af10 #5 2023-11-02 13:46:30 ~55 sec nix-flake 📄log
✖️ 729af10 #6 2023-11-02 13:46:59 ~1 min tests 📄log
✔️ 729af10 #5 2023-11-02 13:48:53 ~3 min android 📦tgz
✔️ 729af10 #5 2023-11-02 14:01:13 ~15 min ios 📦tgz
✖️ e163821 #7 2023-11-04 03:12:52 ~29 sec tests 📄log
✖️ e163821 #6 2023-11-04 03:12:52 ~30 sec tests 📄log
✖️ e163821 #6 2023-11-04 03:13:16 ~55 sec nix-flake 📄log
e163821 #6 2023-11-04 03:13:24 ~1 min linux 📄log
e163821 #7 2023-11-04 03:13:46 ~19 sec linux 📄log
✔️ e163821 #7 2023-11-04 03:16:26 ~3 min ios 📦tgz
✔️ e163821 #6 2023-11-04 03:16:32 ~4 min ios 📦tgz
✔️ e163821 #6 2023-11-04 03:16:53 ~4 min android 📦tgz
✔️ e163821 #7 2023-11-04 03:20:13 ~3 min android 📦tgz
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ a31d3a4 #8 2023-11-04 06:55:55 ~1 min linux 📦deb
✖️ a31d3a4 #8 2023-11-04 06:56:03 ~1 min tests 📄log
✔️ a31d3a4 #7 2023-11-04 06:56:35 ~1 min nix-flake 📄log
✔️ a31d3a4 #7 2023-11-04 06:58:44 ~4 min tests 📄log
✔️ a31d3a4 #8 2023-11-04 06:58:53 ~4 min ios 📦tgz
✔️ a31d3a4 #8 2023-11-04 06:59:16 ~4 min android 📦tgz
✔️ a31d3a4 #9 2023-11-04 07:07:58 ~2 min tests 📄log
✔️ 0e24fc7 #9 2023-11-04 07:19:17 ~1 min linux 📦deb
✔️ 0e24fc7 #8 2023-11-04 07:19:29 ~1 min nix-flake 📄log
✔️ 0e24fc7 #8 2023-11-04 07:19:38 ~2 min tests 📄log
✔️ 0e24fc7 #10 2023-11-04 07:20:10 ~2 min tests 📄log
✔️ 0e24fc7 #9 2023-11-04 07:20:52 ~3 min ios 📦tgz
✔️ 0e24fc7 #9 2023-11-04 07:21:11 ~3 min android 📦tgz

func (s *FilterService) writeGetMessageErr(w http.ResponseWriter, err error, code int) {
// write status before the body
w.WriteHeader(code)
s.log.Error("get message", zap.Error(err))

Check failure

Code scanning / CodeQL

Log entries created from user input High

This log entry depends on a
user-provided value
.
@harsh-98 harsh-98 marked this pull request as ready for review November 1, 2023 15:53
Copy link
Member

@richard-ramos richard-ramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Left few comments/questions

cmd/waku/server/rest/waku_rest.go Show resolved Hide resolved
cmd/waku/server/rest/waku_rest.go Show resolved Hide resolved
cmd/waku/server/rest/filter_cache.go Outdated Show resolved Hide resolved
@richard-ramos richard-ramos changed the title Rest filterv2 get message feat(rest-filterv2): get message Nov 2, 2023
harsh-98 and others added 2 commits November 2, 2023 20:37
Co-authored-by: richΛrd <info@richardramos.me>
@harsh-98 harsh-98 changed the base branch from SubMapEncapsulation to master November 4, 2023 03:12
@harsh-98 harsh-98 merged commit 532a040 into master Nov 4, 2023
8 of 11 checks passed
@harsh-98 harsh-98 deleted the RestFilterv2GetMessage branch November 4, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants