Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: discv5 filter out nodes that have empty waku capabilities #865

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

chaitanyaprem
Copy link
Collaborator

@chaitanyaprem chaitanyaprem commented Nov 6, 2023

Description

Refer #863

Changes

  • DiscoveryV5 evaluation to include check for Waku2 ENR field and fail if field is present and empty
  • Add test to validate discv5 filtering for node without waku capability.

Tests

@status-im-auto
Copy link

status-im-auto commented Nov 6, 2023

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ e9bf3ce #1 2023-11-06 10:40:45 ~1 min nix-flake 📄log
✔️ e9bf3ce #1 2023-11-06 10:41:24 ~2 min linux 📦deb
✔️ e9bf3ce #1 2023-11-06 10:42:15 ~3 min tests 📄log
✔️ e9bf3ce #1 2023-11-06 10:42:37 ~3 min tests 📄log
✔️ e9bf3ce #1 2023-11-06 10:42:40 ~3 min ios 📦tgz
✔️ e9bf3ce #1 2023-11-06 10:42:54 ~4 min android 📦tgz

@chaitanyaprem chaitanyaprem merged commit 9315de8 into master Nov 7, 2023
12 of 13 checks passed
@chaitanyaprem chaitanyaprem deleted the feat/discv5-filtering branch November 7, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants