chore: remove --store-message-db-vacuum
#883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richard-ramos
changed the title
--store-message-db-vacuum
yakimant
approved these changes
Nov 8, 2023
There was a problem hiding this comment.
Another option is https://sqlite.org/pragma.html#pragma_auto_vacuum
But I agree in general - not a part of waku code.
Jenkins Builds
|
|
lgtm. |
harsh-98
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
VACUUM, as described in waku-org/nwaku#2165 is an operation that takes a substantial amount of time to be executed depending on the number of rows in the database. Based on the experience so far since the introduction of this flag, It's for the better to execute this command as an operation done via cron or manually, instead of having it be part of the code of waku.Changes
DBSettingsstruct, since we might end up having to setup some RDBMS specific setting in the future?