fix: rest get messages not returning more than 1 message #898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins Builds
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| select { | ||
| case envelope, open := <-sub.Ch: | ||
| if !open { | ||
| r.log.Error("consume channel is closed for subscription", zap.String("pubsubTopic", topic)) |
Check failure
Code scanning / CodeQL
Log entries created from user input High
richard-ramos
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Getting relay messages via REST API was not working correctly as it would only return a single message due to having a select with a default case without having a loop to drain the channel.
Changes
Tests
Tested locally using default pubsubtopic and noticed that messages were returned until channel is drained.