Update to RLN v2 #21
Merged
Update to RLN v2 #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alrevuelta
commented
May 21, 2024
•
alrevuelta
commented
- Updates to support RLN v2
- Changes:
- x86: chore: bump zerokit to v0.5.0 including RLN v2 go-zerokit-rln-x86_64#4
- apple: chore: bump zerokit to v0.5.0 including RLN v2 go-zerokit-rln-apple#6
- arm: chore: bump zerokit to v0.5.0 including RLN v2 go-zerokit-rln-arm#4
rln/rln.go
Outdated
| func (r *RLN) MembershipKeyGen() (*IdentityCredential, error) { | ||
| // Accepts an optional parameter that sets the user message limit which defaults | ||
| // to DEFAULT_USER_MESSAGE_LIMIT | ||
| func (r *RLN) MembershipKeyGen(params ...uint32) (*IdentityCredential, error) { |
There was a problem hiding this comment.
I wonder if it wouldnt be better to rename params to userMessageLimit`?
rln/rln.go
Outdated
Comment on lines
231
to
232
| if len(proofBytes) != 288 { | ||
| return nil, fmt.Errorf("invalid proof generated. size: %d expected: 288", |
There was a problem hiding this comment.
Since 288 is used both in this and next line, it's probably better to extract to a constant and then the error should be fmt.Errorf("invalid proof generated. size: %d expected: %d", len(proofBytes), yourConstant)
richard-ramos
approved these changes
May 23, 2024
rymnc
approved these changes
May 24, 2024
Closed
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.