-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: standardise exports to camel case #1933
Comments
Can I start working on it? |
of course @varunsh20 ! ping me if you need any help with it |
sounds good -- let's confirm the scope of this issue before we move forward. @waku-org/js-waku-developers are we deciding to stick with camel case? |
we already are using camel case almost everywhere for our code (as you noted - not files or packages tought)
I think we can keep files for later to be changed, maybe as follow up @danisharora099 @varunsh20 good observation. To me it seems fine to rename cc @waku-org/js-waku-developers |
Please review it and let me know if any changes are required. |
@varunsh20 apologies for such long reply as our team had some activities this month. Ping if your are willing to complete this task or interested in contributing more! |
@varunsh20 I had left a review on your PR #1934 (comment) |
Hey @varunsh20 are you still interested in addressing comments on the PR? Mostly seems good, just need to ensure CI passes. |
Up for grabs again |
This is a change request
Problem
We currently have camel case as well as snake case exports within our codebase:
Proposed Solutions
Standardise it to use camel case
Notes
@waku/sdk
#1913 (comment)The text was updated successfully, but these errors were encountered: