Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: changing exports name from snake casing to camel case #1934

Closed
wants to merge 2 commits into from
Closed

fix!: changing exports name from snake casing to camel case #1934

wants to merge 2 commits into from

Conversation

varunsh20
Copy link

Problem

Some exports are using snake casing within the codebase.

Solution

Have changed the exports name in core and proto packages to camel case.

Notes

@varunsh20 varunsh20 requested a review from a team as a code owner March 29, 2024 10:48
@varunsh20 varunsh20 changed the title Changing exports name from snake casing to camel case fix: changing exports name from snake casing to camel case Mar 29, 2024
danisharora099
danisharora099 requested changes Apr 1, 2024
View reviewed changes
Copy link
Collaborator

@danisharora099 danisharora099 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some changes I can see:

  • update imports for the changed exports
  • change the PR title to include ! to convey a breaking change

@varunsh20 varunsh20 changed the title fix: changing exports name from snake casing to camel case fix!: changing exports name from snake casing to camel case Apr 1, 2024
@varunsh20
Copy link
Author

@danisharora099 changes done. Correct me if I am wrong but I think some exports like waku_filter, waku_store and few others are not used currently. Rest I have changed.

@danisharora099
Copy link
Collaborator

@danisharora099 changes done. Correct me if I am wrong but I think some exports like waku_filter, waku_store and few others are not used currently. Rest I have changed.

@varunsh20
Yes. Would suggest at fixing the CI runs which would implicitly take care a lot of smaller things. Will come back for a final review then

@danisharora099
Copy link
Collaborator

Hi @varunsh20 are you still interested in this PR?
If not, we can close it.

@danisharora099 danisharora099 mentioned this pull request Apr 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danisharora099 danisharora099 Awaiting requested review from danisharora099

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore: standardise exports to camel case
2 participants
@varunsh20 @danisharora099