-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: @waku/relay #1316
feat!: @waku/relay #1316
Changes from 3 commits
00145ec
39667ed
cd9a482
dff2c45
5bcbcea
c593ce6
76df4cb
522c161
9222587
8646f7c
4b0ce8b
ab2fc55
d73bcf8
3021783
907e30c
6e7a0f6
41ffc35
0266041
74b53e6
a61a5ca
5f33dbb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -53,6 +53,7 @@ | |
"@libp2p/websockets": "^5.0.3", | ||
"@waku/core": "0.0.16", | ||
"@waku/dns-discovery": "0.0.10", | ||
"@waku/relay": "^0.0.1", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @weboko didn't we say we would keep There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I have addressed this as part of this PR: 41ffc35 I'm curious if we could possibly make this change automatically part of the pre-commit hook maybe There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. did some digging; tracking here: #1346 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @fryorcraken , right now we have a mix: some are using asterisk and some version. Honestly I can't remember on what we settled but it seems to me now we agreed that version will be changed / maintained by @danisharora099 I believe the task is not needed except if we want to define versions to private packages, I think they won't be changed automatically by the release CI. That can be done manually it seems. |
||
"libp2p": "^0.42.2" | ||
}, | ||
"devDependencies": { | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
module.exports = { | ||
parserOptions: { | ||
tsconfigRootDir: __dirname, | ||
project: "./tsconfig.dev.json", | ||
}, | ||
}; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
{ | ||
"extension": ["ts"], | ||
"spec": "src/**/*.spec.ts", | ||
"require": ["ts-node/register", "isomorphic-fetch"], | ||
"loader": "ts-node/esm", | ||
"node-option": [ | ||
"experimental-specifier-resolution=node", | ||
"loader=ts-node/esm" | ||
], | ||
"exit": true | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removes
libp2p-gossipsub
dependency fromcore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you double check whether any other dependency can be removed such as
@libp2p/interface-pubsub
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
We could possibly use something like https://github.com/depcheck/depcheck to achieve receiving updates on unused dependency errors.