-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: export crypto primitives #1728
Conversation
This PR is mostly re-naming and exporting of existing functions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
size-limit report 📦
|
…weboko/encryption
@danisharora099 thanks for the PR and I also agree that it is better to get the |
@waku-org/js-waku-developers I believe this PR should be reverted as it encourages metadata leaking by enabling developers to partial message encryption. |
This reverts commit 7eb3375
Problem
In some cases users don't want to encrypt whole
payload
but only some part of it to have additional features.To do some one would need to implement encryption on their own or find a library.
Solution
Export already implemented primitives to allows consumers build more features.
Notes
Follow-up