chore: upgrade protons + commit new proto code #1898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danisharora099
force-pushed
the
chore/lockfile
branch
from
cda6702 to
e8c7405
Compare
size-limit report 📦
|
danisharora099
force-pushed
the
chore/lockfile
branch
from
d749806 to
ef6c55d
Compare
danisharora099
changed the title
danisharora099
changed the title
danisharora099
commented
Mar 28, 2024
| @@ -191,7 +191,7 @@ describe("Waku Store, cursor", function () { | |||
| for await (const page of waku.store.queryGenerator([TestDecoder], { | |||
| cursor | |||
| })) { | |||
| page; | |||
| void page; | |||
There was a problem hiding this comment.
side change that eslint complained about
Comment on lines
+187
to
196
| // ensure the connection is closed from the other side | ||
| let counter = 0; | ||
| while (waku.libp2p.getConnections().length !== 0) { | ||
| if (counter > 10) { | ||
| console.error("Connection was not closed"); | ||
| break; | ||
| } | ||
| await delay(100); | ||
| counter++; | ||
| } | ||
|
|
There was a problem hiding this comment.
side change to handle flaky tests
danisharora099
changed the title
danisharora099
force-pushed
the
chore/lockfile
branch
from
3bcc2de to
2dedc5e
Compare
danisharora099
force-pushed
the
chore/lockfile
branch
from
3e19fba to
de2b94a
Compare
adklempner
reviewed
Apr 6, 2024
adklempner
reviewed
Apr 6, 2024
adklempner
reviewed
Apr 6, 2024
adklempner
reviewed
Apr 6, 2024
adklempner
reviewed
Apr 6, 2024
adklempner
approved these changes
Apr 7, 2024
There was a problem hiding this comment.
discussed with @danisharora099 and approved; we don't use the new opts that are generated by upgraded protons so my comments are irrelevant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The new release of
protonschanges how they compile proto definitions intotsfiles which breaks our commited proto code CI check ref: chore(deps)(deps-dev): bump protons from 7.0.5 to 7.4.0 #1932We are deprecating a few packages like
@waku/peer-exchange,@waku/dns-discovery, etc in favour of introducing a new package@waku/discovery: feat!: @waku/discovery #1876 which leaves (non-breaking) stale references and outdated entriesalso: https://github.com/waku-org/js-waku/actions/runs/8209802396/job/22456033863?pr=1889
Solution
This should be followed by generating a new lockfile (ref: #1810 (comment))
Notes
protodefinitions into thelibsubdir and the generated TS files into thegensubdir