Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove stale references to deprecated packages #1936

Merged
merged 1 commit into from
Apr 7, 2024

Conversation

danisharora099
Copy link
Collaborator

Problem

We moved individual discovery packages (@waku/dns-discovery, @waku/peer-exchange, @waku/local-peer-cache-discovery) under one single package: @waku/discovery: #1876

Some references in @waku/sdk remained

Solution

Remove these references

Notes

Contribution checklist:

  • covered by unit tests;
  • covered by e2e test;
  • add ! in title if breaks public API;

@danisharora099 danisharora099 requested a review from a team as a code owner April 7, 2024 10:37
Copy link

github-actions bot commented Apr 7, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku node 180.58 KB (-0.14% 🔽) 3.7 s (-0.14% 🔽) 21.1 s (+39.25% 🔺) 24.7 s
Waku Simple Light Node 180.75 KB (-0.06% 🔽) 3.7 s (-0.06% 🔽) 19.6 s (+27.71% 🔺) 23.2 s
ECIES encryption 23.11 KB (0%) 463 ms (0%) 3.2 s (-30.04% 🔽) 3.7 s
Symmetric encryption 22.58 KB (0%) 452 ms (0%) 3.6 s (-41.16% 🔽) 4 s
DNS discovery 72.4 KB (0%) 1.5 s (0%) 6.7 s (-50.55% 🔽) 8.1 s
Peer Exchange discovery 73.97 KB (0%) 1.5 s (0%) 8.8 s (+11.47% 🔺) 10.3 s
Local Peer Cache Discovery 67.71 KB (0%) 1.4 s (0%) 9.1 s (-21.34% 🔽) 10.5 s
Privacy preserving protocols 38.75 KB (0%) 775 ms (0%) 4.5 s (-51.07% 🔽) 5.3 s
Waku Filter 20.17 KB (0%) 404 ms (0%) 3.9 s (+27.15% 🔺) 4.3 s
Waku LightPush 110.12 KB (+0.04% 🔺) 2.3 s (+0.04% 🔺) 10 s (-6.54% 🔽) 12.2 s
History retrieval protocols 110.62 KB (-0.14% 🔽) 2.3 s (-0.14% 🔽) 9.9 s (+5.91% 🔺) 12.1 s
Deterministic Message Hashing 4.83 KB (0%) 97 ms (0%) 1.9 s (+234.95% 🔺) 2 s

Copy link
Collaborator

@weboko weboko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uh, that's good that we didn't release it

@weboko weboko merged commit 86058c5 into master Apr 7, 2024
8 of 10 checks passed
@weboko weboko deleted the fix/discovery-leak branch April 7, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants