feat: add keep alive to Filter #1970
Conversation
… mapping default for decoder / encoder
|
Draft for now before #1958 is merged. |
size-limit report 📦
|
packages/sdk/src/protocols/filter.ts
Outdated
| return; | ||
| } | ||
|
|
||
| this.keepAliveTimer = window.setInterval(() => { |
There was a problem hiding this comment.
using window here might be limiting and could cause breaking API in nodejs env
I think just using setInterval/clearInterval should implicitly polyfill
There was a problem hiding this comment.
good point, the reason why I went with window is to make typescript understand that it is browser API, otherwise I need to suppress types
making it using API directly with type trick
There was a problem hiding this comment.
otherwise I need to suppress types
the types natively exist in TypeScript -- no need to supress types
There was a problem hiding this comment.
there is an ambiguity in types
in nodejs it returns NodeJS.Timeout - https://github.com/DefinitelyTyped/DefinitelyTyped/blob/778ad7a80e9876f258270d84d1db4e6e1d5e3796/types/node/timers.d.ts#L191
where as in browser it is a number
hence the need to do as number to help TS determine it is browser interface
|
Why can't we use the existing keep alive manager for this? Or why is it insufficient? |
This is because |
weboko
changed the title
Problem
Filter doesn't keep keep subscription forever and requires periodic pings.
Solution
Implement
keep alivefeature to do automatic pings to the peers.Notes